Add GERAPY_PLAYWRIGHT_BROWSER_TYPE setting#20
Draft
feder-cr wants to merge 1 commit into
Draft
Conversation
executable_path was already configurable but the launch call was hardcoded to playwright.chromium.launch(), so pointing it at a non-Chromium binary wouldn't actually work. Adds a browser_type setting (defaults to 'chromium', unchanged behavior) and guards the Chromium-only launch args behind it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
executable_path was already configurable but the launch call was hardcoded to playwright.chromium.launch(), so pointing it at a Firefox (or WebKit) binary wouldn't actually work correctly. This adds a GERAPY_PLAYWRIGHT_BROWSER_TYPE setting, defaults to 'chromium' so nothing changes unless it's set explicitly, and guards the Chromium-only launch args behind it. Motivated by invisible_playwright, a Playwright wrapper around a Firefox build patched at the source level for a realistic fingerprint. Opened as draft, happy to adjust naming or split into smaller commits if useful.