feat: catch dscovr end time error and switch model#81
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a DSCOVR-specific fallback path so that when DSCOVR cannot serve data beyond its availability window, the reader switches to ACE (SWACE) instead of failing, and includes a regression test for this behavior.
Changes:
- Catch
ValueErrorfrom DSCOVR reads and fall back to SWACE when DSCOVR data is unavailable past its end time. - Update the default-order warning message to match the actual default model list.
- Add a unit test ensuring DSCOVR end-time errors trigger a single ACE read with expected parameters and output labeling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
swvo/io/solar_wind/read_solar_wind_from_multiple_models.py |
Adds DSCOVR ValueError handling and switches the active model to SWACE on fallback. |
tests/io/solar_wind/test_read_solar_wind_from_multiple_models.py |
Adds coverage for DSCOVR end-time ValueError fallback-to-ACE behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+119
to
+123
| except ValueError as e: | ||
| if not isinstance(model, DSCOVR): | ||
| raise | ||
|
|
||
| logger.warning(f"Failed to read DSCOVR data because: {e}. Falling back to ACE.") |
Comment on lines
+130
to
+132
| else: | ||
| active_model = SWACE(Path("./data")) | ||
| logger.info("Falling back to a new instance of SWACE model with default data directory './data'.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.