Skip to content

chore: fix wdc time assertion #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sahiljhawar merged 1 commit into from
Jul 9, 2026
Merged

chore: fix wdc time assertion #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions swvo/io/dst/wdc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ def download_and_process(self, start_time: datetime, end_time: datetime, reproce
None
"""

assert start_time < end_time, "Start time must be before end time"
start_time = enforce_utc_timezone(start_time)
end_time = enforce_utc_timezone(end_time)

assert start_time < end_time, "Start time must be before end time!"

temporary_dir = Path("./temp_wdc")
temporary_dir.mkdir(exist_ok=True, parents=True)
Expand Down Expand Up @@ -225,11 +228,6 @@ def read(self, start_time: datetime, end_time: datetime, download: bool = False)
WDC Dst data.
"""

if start_time > end_time:
msg = "start_time must be before end_time"
logger.error(msg)
raise ValueError(msg)

start_time = enforce_utc_timezone(start_time)
end_time = enforce_utc_timezone(end_time)

Expand Down
Loading