Skip to content

Validate abstract grid coordinate dimensionality#3207

Open
FlorianPfaff wants to merge 2 commits into
mainfrom
codex/fix-grid-coordinate-dimension-validation
Open

Validate abstract grid coordinate dimensionality#3207
FlorianPfaff wants to merge 2 commits into
mainfrom
codex/fix-grid-coordinate-dimension-validation

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Fix AbstractGridDistribution coordinate validation so 1-D grid coordinates are treated as one-dimensional coordinates, not silently accepted for higher-dimensional distributions.
  • Reject rank > 2 coordinate tensors instead of accepting them when shape[1] happens to match dim.
  • Add regression coverage for both malformed coordinate cases.

Bug fixed

Before this change, DummyGridDistribution(array([1.0, 1.0]), grid=array([0.0, 1.0]), dim=2) passed constructor validation even though the stored coordinates are one-dimensional. Similarly, rank-3 coordinate arrays could pass validation accidentally.

Testing

  • python -m py_compile /tmp/abstract_grid_distribution.py /tmp/test_abstract_grid_distribution.py

Full project tests are expected to run in GitHub Actions on the PR.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 73.79s
✅ JSON prettier 7 0 0 0 1.04s
✅ JSON v8r 7 0 0 6.65s
✅ MARKDOWN markdownlint 68 0 0 0 2.14s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.64s
✅ PYTHON black 1038 43 0 0 66.45s
✅ PYTHON isort 1038 61 0 0 6.66s
✅ REPOSITORY checkov yes no no 47.47s
✅ REPOSITORY gitleaks yes no no 10.3s
✅ REPOSITORY git_diff yes no no 0.1s
✅ REPOSITORY secretlint yes no no 31.85s
✅ REPOSITORY syft yes no no 3.78s
✅ REPOSITORY trivy-sbom yes no no 11.73s
✅ REPOSITORY trufflehog yes no no 22.49s
✅ YAML prettier 11 0 0 0 0.73s
✅ YAML v8r 11 0 0 10.31s
✅ YAML yamllint 11 0 0 0.61s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant