Skip to content

Validate hyperrectangular integration PDF outputs#3192

Open
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-hyperrect-integrate-pdf-validation
Open

Validate hyperrectangular integration PDF outputs#3192
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-hyperrect-integrate-pdf-validation

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Validate AbstractHyperrectangularDistribution.integrate() PDF evaluations before passing values to SciPy quadrature.
  • Reject empty, vector/multi-value, non-real, and non-finite pdf outputs instead of flattening and integrating the first value.
  • Add regression tests for vector and NaN custom hyperrectangular PDFs while preserving scalar-output integration behavior.

Bug fixed

integrate() previously did float(to_numpy(array(values)).reshape(-1)[0]) for each quadrature point. A malformed custom PDF returning multiple values for one point could therefore be silently reduced to its first value, producing a plausible but wrong integral. Non-finite values were also not rejected at the PyRecEst boundary.

Validation

  • Syntax-checked the modified source and test files locally with ast.parse.
  • Full pytest was not run in this environment because the sandbox cannot resolve github.com to clone/install the repository dependency set.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 60.76s
✅ JSON prettier 7 0 0 0 0.87s
✅ JSON v8r 7 0 0 4.25s
✅ MARKDOWN markdownlint 68 0 0 0 1.52s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.63s
✅ PYTHON black 1036 39 0 0 57.5s
✅ PYTHON isort 1036 57 0 0 4.18s
✅ REPOSITORY checkov yes no no 46.75s
✅ REPOSITORY gitleaks yes no no 9.35s
✅ REPOSITORY git_diff yes no no 0.13s
✅ REPOSITORY secretlint yes no no 34.04s
✅ REPOSITORY syft yes no no 4.41s
✅ REPOSITORY trivy-sbom yes no no 9.96s
✅ REPOSITORY trufflehog yes no no 19.9s
✅ YAML prettier 11 0 0 0 0.75s
✅ YAML v8r 11 0 0 10.42s
✅ YAML yamllint 11 0 0 0.65s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant