Skip to content

Expose matrix methods on PyTorch Rotation stub#3189

Open
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-pytorch-rotation-stub-contract
Open

Expose matrix methods on PyTorch Rotation stub#3189
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-pytorch-rotation-stub-contract

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • add Rotation.from_matrix and Rotation.as_matrix to the PyTorch backend's dummy Rotation class
  • keep the behavior explicitly unsupported, but return the same backend-specific RuntimeError style as the existing quaternion methods
  • add a regression test that checks the matrix methods are present and fail with explicit backend errors

Notes

  • The bug was an inconsistent PyTorch backend API surface: code paths that probe spatial.Rotation.from_matrix could see a missing method instead of the intended explicit unsupported-backend failure.
  • I did not run the full test suite in this connector-only environment; the added test is focused on the patched contract.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 74.59s
✅ JSON prettier 7 0 0 0 1.57s
✅ JSON v8r 7 0 0 5.24s
✅ MARKDOWN markdownlint 68 0 0 0 1.8s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.79s
✅ PYTHON black 1037 39 0 0 63.65s
✅ PYTHON isort 1037 57 0 0 4.94s
✅ REPOSITORY checkov yes no no 48.92s
✅ REPOSITORY gitleaks yes no no 8.88s
✅ REPOSITORY git_diff yes no no 0.24s
✅ REPOSITORY secretlint yes no no 32.3s
✅ REPOSITORY syft yes no no 4.83s
✅ REPOSITORY trivy-sbom yes no no 11.9s
✅ REPOSITORY trufflehog yes no no 21.8s
✅ YAML prettier 11 0 0 0 0.82s
✅ YAML v8r 11 0 0 11.56s
✅ YAML yamllint 11 0 0 0.44s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant