fix: correct doc bugs across 7 files (types, compile errors, typos) - #82
Open
Sertug17 wants to merge 1 commit into
Open
fix: correct doc bugs across 7 files (types, compile errors, typos)#82Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
- FHERC20.md & IFHERC20.md: euint32/inEuint32 → euint128/inEuint128 - Adding View Functions.md: getBalanceEncrypted return type uint256 → uint32 - Types-and-Operators.md: square/euint64 cell <r>✔</r> → <g>✔</g> - Returning-Data.md: euint8 memory → euint8 (value type), add FHE. prefix - Debug-Logging.md: remove EncryptedNumberLibrary, fix Console.log, fix return - Security-Zones.md: add calldata to inEuint32 params, fix econd → second Closes FhenixProtocol#76 FhenixProtocol#77 FhenixProtocol#78 FhenixProtocol#79 FhenixProtocol#80 FhenixProtocol#81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes 6 confirmed documentation bugs found during a code audit.
Changes
euint32/inEuint32→euint128/inEuint128to match actual contract;_allowanceEncryptedvisibility correctedpublic→internalgetBalanceEncryptedreturn type correcteduint256→uint32square/euint64cell fixed from<r>✔</r>to<g>✔</g>euint8 memory foofixed toeuint8 foo(value type, no data location); added missingFHE.prefix toasEuint8()EncryptedNumberLibrary; fixedConsole.logto use decrypted value; removedreturnfrom void functioncalldatadata location toinEuint32parameters; fixed JS typoecond→secondCloses
#76 #77 #78 #79 #80 #81