Fix two regex patterns which behaves too greedy - #613
Open
ITaluone wants to merge 1 commit into
Open
Conversation
ITaluone
force-pushed
the
fix/patterns-too-greedy
branch
from
July 31, 2026 07:56
b5f3c89 to
1cb53b9
Compare
ITaluone
force-pushed
the
fix/patterns-too-greedy
branch
from
July 31, 2026 07:57
1cb53b9 to
e82563b
Compare
ITaluone
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RewriteCsprojStep'stelemetryVersionPropertyPatternandcryptographyXmlPackageRefPatternacting too greedy.Why?
Leaving the
\s*at the end of the pattern, it consumes every whitespace (including\r,\n) until it finds a non-whitespace (meaning everthing until the next<). This leaves the csproj file wrong indented behind.Fixes: #612