Skip to content

Bump the release-branch prerelease counter to 10.4.0-rc.5 - #594

Merged
ChrisonSimtian merged 1 commit into
Fallout-build:release/v10.4from
ChrisonSimtian:chore/bump-10.4.0-rc.5
Jul 29, 2026
Merged

Bump the release-branch prerelease counter to 10.4.0-rc.5#594
ChrisonSimtian merged 1 commit into
Fallout-build:release/v10.4from
ChrisonSimtian:chore/bump-10.4.0-rc.5

Conversation

@ChrisonSimtian

Copy link
Copy Markdown
Collaborator

Bumps the release-branch prerelease counter from 10.4.0-rc.4 to 10.4.0-rc.5, so the next tag off release/v10.4 ships the two queued cherry-picks.

One-line change to version.json.

Why

On a release branch the prerelease number is a manual counter, not {height} — see branching-and-release.md → Prerelease numbers on a release branch are a manual counter. Tagging without bumping republishes an existing version, and dotnet nuget push --skip-duplicate swallows that silently, so the packages just don't update.

rc.5 is the first RC to carry:

Verification

dotnet pack src/Fallout.Cli on this branch stamps 10.4.0-rc.5. (Locally it also carries a .g<commit> suffix and the pre-#593 plural id, both only because this topic branch isn't a public release ref and doesn't include #593 — on release/v10.4 with both cherry-picks in it stamps Fallout.GlobalTool.10.4.0-rc.5.)

Merge order

Independent of #590 and #593 — no file overlap, so all three can merge in any order. The only ordering that matters is the tag: cut v10.4.0-rc.5 only once all three are on release/v10.4, or the RC ships without the fixes it's numbered for.

@ChrisonSimtian ChrisonSimtian added target/vCurrent Targets the current version skip-changelog labels Jul 28, 2026
@ChrisonSimtian ChrisonSimtian self-assigned this Jul 29, 2026
@ChrisonSimtian
ChrisonSimtian marked this pull request as ready for review July 29, 2026 01:42
@ChrisonSimtian
ChrisonSimtian merged commit 00e49be into Fallout-build:release/v10.4 Jul 29, 2026
3 checks passed
@ChrisonSimtian
ChrisonSimtian deleted the chore/bump-10.4.0-rc.5 branch July 29, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog target/vCurrent Targets the current version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant