Replace toList and mutableList usages with TreeList in all operations - #1038
Merged
Conversation
s5bug
force-pushed
the
vector-fixes-5
branch
6 times, most recently
from
June 12, 2026 02:01
2fee47a to
58cfaa4
Compare
s5bug
force-pushed
the
vector-fixes-5
branch
2 times, most recently
from
July 17, 2026 04:32
055717b to
575fce3
Compare
s5bug
marked this pull request as ready for review
July 17, 2026 04:34
Robotgiggle
requested changes
Aug 8, 2026
Robotgiggle
left a comment
Robotgiggle
left a comment
Member
There was a problem hiding this comment.
Everything looks good except the problem noted below
| return listOf(ListIota(list), last) | ||
| val list = it.nextList(arity) | ||
| val last = if(list.isEmpty()) NullIota() else list.last() | ||
| return listOf(ListIota(list.init()), last) |
Member
There was a problem hiding this comment.
If the list was empty, this attempts to call init() on an empty list, which causes an UnsupportedOperationException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1033