Skip to content

Add COOP_DEPLOYER role to UserRole enum#1148

Open
TimMasalme wants to merge 1 commit into
FAForever:developfrom
TimMasalme:feat/add-coop-deployer-role
Open

Add COOP_DEPLOYER role to UserRole enum#1148
TimMasalme wants to merge 1 commit into
FAForever:developfrom
TimMasalme:feat/add-coop-deployer-role

Conversation

@TimMasalme

@TimMasalme TimMasalme commented Jun 23, 2026

Copy link
Copy Markdown

Summary

Adds the COOP_DEPLOYER role to the UserRole enum.

This role is required for the new faf-coop-deployer service
(https://github.com/TimMasalme/coop-deployer), which replaces the manual
Kotlin scripts run by Brutus/Sheikah for co-op map and patch deployment.

Users with this role can trigger map and patch deployments via a REST API
instead of requiring direct database and shell access.

How to assign the role

Once this is merged, the COOP_DEPLOYER group can be created and managed
via the existing User Groups tab in Mordor — no further UI changes needed.

Summary by CodeRabbit

  • New Features
    • Added support for the "COOP_DEPLOYER" role, enabling expanded authorization capabilities within the system.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7f595bfc-8694-4e19-bcaf-d130192593ec

📥 Commits

Reviewing files that changed from the base of the PR and between 39eea66 and 9e8d558.

📒 Files selected for processing (1)
  • src/main/java/com/faforever/api/security/UserRole.java

📝 Walkthrough

Walkthrough

A new COOP_DEPLOYER("COOP_DEPLOYER") constant is added to the UserRole enum in UserRole.java. The existing fromString map and getAuthority() method automatically incorporate the new constant without further changes.

Changes

Add COOP_DEPLOYER UserRole constant

Layer / File(s) Summary
COOP_DEPLOYER enum constant
src/main/java/com/faforever/api/security/UserRole.java
Adds COOP_DEPLOYER("COOP_DEPLOYER") to the UserRole enum; the existing fromString map and getAuthority() method automatically include it.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A new role hops into the code today,
COOP_DEPLOYER has finally found its way!
The enum map stretched to make some room,
Authority granted — no more gloom.
With one small line the rabbit cheers,
Deploy the coops across the years! 🚀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely summarizes the main change: adding a new COOP_DEPLOYER role to the UserRole enum, which is the primary purpose of the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant