Recommend Ethers.Signature over the EOA-only verification helpers#268
Merged
Conversation
Document Ethers.TypedData.recover_signer/2, valid_signature?/3 and Ethers.PersonalMessage.verify/3 as EOA-only and explicitly recommend Ethers.Signature.verify_typed_data/4 / verify_message/4 which also support smart-contract wallets (ERC-1271/ERC-6492). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #266.
Ethers.Signature.verify_typed_data/4/verify_message/4already provide universal (EOA + ERC-1271 + ERC-6492) verification, but the EOA-only helpers didn't steer readers to them — backends usingEthers.TypedData.valid_signature?/3orEthers.PersonalMessage.verify/3silently reject all smart-wallet users.This documents those helpers (plus
recover_signer/2, which is inherently EOA-only — contract wallets have no recoverable signer) with an explicit recommendation: preferEthers.Signatureto support smart-contract wallets too; use the pure helpers when you specifically need an RPC-free check for signatures known to come from EOA keys.Doc-only change; no behavior affected.
🤖 Generated with Claude Code