Skip to content

Prepare crates for crates.io publishing#14

Merged
IliaMManolov merged 2 commits into
mainfrom
cargo_publish
Jul 14, 2026
Merged

Prepare crates for crates.io publishing#14
IliaMManolov merged 2 commits into
mainfrom
cargo_publish

Conversation

@IliaMManolov

@IliaMManolov IliaMManolov commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary by cubic

Prepared crates for crates.io: renamed the wire‑protocol crate to edison-tunnel-protocol, updated references, added publishing metadata, and fixed import ordering after the rename.

  • Migration
    • Update Cargo.toml: replace tunnel-protocol with edison-tunnel-protocol = "0.0.1".
    • Update Rust imports: use edison_tunnel_protocol::....
    • Update schema references to schema/edison-tunnel-protocol.json.

Written for commit 356e3a8. Summary will update on new commits.

Review in cubic

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QNXkCRxAip5uDbzdjjSi7t

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found and verified against the latest diff

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="dev/spike/README.md">

<violation number="1" location="dev/spike/README.md:13">
P3: README references `edison_tunnel_protocol.py` but the actual file on disk is still named `tunnel_protocol.py`. Update the README to match the actual filename, or rename the file to match.</violation>
</file>

<file name="CONTRIBUTING.md">

<violation number="1" location="CONTRIBUTING.md:43">
P2: The schema reference in CONTRIBUTING.md now points to `schema/edison-tunnel-protocol.json`, but that file doesn't exist yet — only `schema/tunnel-protocol.json` is present. This creates a broken documentation link for contributors. Consider renaming the schema file to match (since README.md also references the `edison-` prefixed name) or revert the references until the rename is done.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread CONTRIBUTING.md
and module layout; `cargo fmt` handles formatting.
- **Update docs alongside code.** If you change the wire protocol, update
[`schema/tunnel-protocol.json`](./schema/tunnel-protocol.json) (the single
[`schema/edison-tunnel-protocol.json`](./schema/edison-tunnel-protocol.json) (the single

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The schema reference in CONTRIBUTING.md now points to schema/edison-tunnel-protocol.json, but that file doesn't exist yet — only schema/tunnel-protocol.json is present. This creates a broken documentation link for contributors. Consider renaming the schema file to match (since README.md also references the edison- prefixed name) or revert the references until the rename is done.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At CONTRIBUTING.md, line 43:

<comment>The schema reference in CONTRIBUTING.md now points to `schema/edison-tunnel-protocol.json`, but that file doesn't exist yet — only `schema/tunnel-protocol.json` is present. This creates a broken documentation link for contributors. Consider renaming the schema file to match (since README.md also references the `edison-` prefixed name) or revert the references until the rename is done.</comment>

<file context>
@@ -40,7 +40,7 @@ cargo fmt --all --check && \
   and module layout; `cargo fmt` handles formatting.
 - **Update docs alongside code.** If you change the wire protocol, update
-  [`schema/tunnel-protocol.json`](./schema/tunnel-protocol.json) (the single
+  [`schema/edison-tunnel-protocol.json`](./schema/edison-tunnel-protocol.json) (the single
   source of truth) and [`ARCHITECTURE.md`](./ARCHITECTURE.md). If you change the
   CLI or config, update [`README.md`](./README.md).
</file context>

Comment thread dev/spike/README.md
```
stub_mcp_server.py FastMCP stdio server: add, slow_count, ask_sample, crash
tunnel_protocol.py Pydantic models for the wire envelope (ClientHello,
edison_tunnel_protocol.py Pydantic models for the wire envelope (ClientHello,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: README references edison_tunnel_protocol.py but the actual file on disk is still named tunnel_protocol.py. Update the README to match the actual filename, or rename the file to match.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At dev/spike/README.md, line 13:

<comment>README references `edison_tunnel_protocol.py` but the actual file on disk is still named `tunnel_protocol.py`. Update the README to match the actual filename, or rename the file to match.</comment>

<file context>
@@ -10,7 +10,7 @@ kept here as a historical record, not part of the daemon build.

stub_mcp_server.py FastMCP stdio server: add, slow_count, ask_sample, crash
-tunnel_protocol.py Pydantic models for the wire envelope (ClientHello,
+edison_tunnel_protocol.py Pydantic models for the wire envelope (ClientHello,
ServerHello, McpFrame, TunnelError)
tunnel_transport.py Custom ClientTransport. Wraps SessionMessages as
</file context>


</details>

```suggestion
tunnel_protocol.py   Pydantic models for the wire envelope (ClientHello,

@IliaMManolov
IliaMManolov merged commit 431aefb into main Jul 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant