Prepare crates for crates.io publishing#14
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QNXkCRxAip5uDbzdjjSi7t
There was a problem hiding this comment.
2 issues found and verified against the latest diff
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="dev/spike/README.md">
<violation number="1" location="dev/spike/README.md:13">
P3: README references `edison_tunnel_protocol.py` but the actual file on disk is still named `tunnel_protocol.py`. Update the README to match the actual filename, or rename the file to match.</violation>
</file>
<file name="CONTRIBUTING.md">
<violation number="1" location="CONTRIBUTING.md:43">
P2: The schema reference in CONTRIBUTING.md now points to `schema/edison-tunnel-protocol.json`, but that file doesn't exist yet — only `schema/tunnel-protocol.json` is present. This creates a broken documentation link for contributors. Consider renaming the schema file to match (since README.md also references the `edison-` prefixed name) or revert the references until the rename is done.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| and module layout; `cargo fmt` handles formatting. | ||
| - **Update docs alongside code.** If you change the wire protocol, update | ||
| [`schema/tunnel-protocol.json`](./schema/tunnel-protocol.json) (the single | ||
| [`schema/edison-tunnel-protocol.json`](./schema/edison-tunnel-protocol.json) (the single |
There was a problem hiding this comment.
P2: The schema reference in CONTRIBUTING.md now points to schema/edison-tunnel-protocol.json, but that file doesn't exist yet — only schema/tunnel-protocol.json is present. This creates a broken documentation link for contributors. Consider renaming the schema file to match (since README.md also references the edison- prefixed name) or revert the references until the rename is done.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At CONTRIBUTING.md, line 43:
<comment>The schema reference in CONTRIBUTING.md now points to `schema/edison-tunnel-protocol.json`, but that file doesn't exist yet — only `schema/tunnel-protocol.json` is present. This creates a broken documentation link for contributors. Consider renaming the schema file to match (since README.md also references the `edison-` prefixed name) or revert the references until the rename is done.</comment>
<file context>
@@ -40,7 +40,7 @@ cargo fmt --all --check && \
and module layout; `cargo fmt` handles formatting.
- **Update docs alongside code.** If you change the wire protocol, update
- [`schema/tunnel-protocol.json`](./schema/tunnel-protocol.json) (the single
+ [`schema/edison-tunnel-protocol.json`](./schema/edison-tunnel-protocol.json) (the single
source of truth) and [`ARCHITECTURE.md`](./ARCHITECTURE.md). If you change the
CLI or config, update [`README.md`](./README.md).
</file context>
| ``` | ||
| stub_mcp_server.py FastMCP stdio server: add, slow_count, ask_sample, crash | ||
| tunnel_protocol.py Pydantic models for the wire envelope (ClientHello, | ||
| edison_tunnel_protocol.py Pydantic models for the wire envelope (ClientHello, |
There was a problem hiding this comment.
P3: README references edison_tunnel_protocol.py but the actual file on disk is still named tunnel_protocol.py. Update the README to match the actual filename, or rename the file to match.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At dev/spike/README.md, line 13:
<comment>README references `edison_tunnel_protocol.py` but the actual file on disk is still named `tunnel_protocol.py`. Update the README to match the actual filename, or rename the file to match.</comment>
<file context>
@@ -10,7 +10,7 @@ kept here as a historical record, not part of the daemon build.
stub_mcp_server.py FastMCP stdio server: add, slow_count, ask_sample, crash
-tunnel_protocol.py Pydantic models for the wire envelope (ClientHello,
+edison_tunnel_protocol.py Pydantic models for the wire envelope (ClientHello,
ServerHello, McpFrame, TunnelError)
tunnel_transport.py Custom ClientTransport. Wraps SessionMessages as
</file context>
</details>
```suggestion
tunnel_protocol.py Pydantic models for the wire envelope (ClientHello,
Summary by cubic
Prepared crates for crates.io: renamed the wire‑protocol crate to
edison-tunnel-protocol, updated references, added publishing metadata, and fixed import ordering after the rename.tunnel-protocolwithedison-tunnel-protocol = "0.0.1".use edison_tunnel_protocol::....schema/edison-tunnel-protocol.json.Written for commit 356e3a8. Summary will update on new commits.