Remove detect/quarantine fs ops from client#38
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 21 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/main/ipc/ipcHandlersMcpSubmit.ts">
<violation number="1" location="src/main/ipc/ipcHandlersMcpSubmit.ts:339">
P2: Already registered or pending servers will no longer be represented as `alreadyOnBackend`; an idempotent daemon acknowledgement is counted as a fresh submission, while a backend conflict becomes a rename failure. Preserving the backend-status classification in the daemon response or retaining an equivalent preflight would keep onboarding results and follow-up actions correct.</violation>
</file>
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Re-trigger cubic
| }; | ||
| // The daemon owns submit and auto-templatizes detected secrets, so the | ||
| // manual template overrides don't apply; route through the daemon. | ||
| const summary = await submitServersViaDetectord(servers); |
There was a problem hiding this comment.
P2: Already registered or pending servers will no longer be represented as alreadyOnBackend; an idempotent daemon acknowledgement is counted as a fresh submission, while a backend conflict becomes a rename failure. Preserving the backend-status classification in the daemon response or retaining an equivalent preflight would keep onboarding results and follow-up actions correct.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/main/ipc/ipcHandlersMcpSubmit.ts, line 339:
<comment>Already registered or pending servers will no longer be represented as `alreadyOnBackend`; an idempotent daemon acknowledgement is counted as a fresh submission, while a backend conflict becomes a rename failure. Preserving the backend-status classification in the daemon response or retaining an equivalent preflight would keep onboarding results and follow-up actions correct.</comment>
<file context>
@@ -428,123 +323,22 @@ export function registerMcpSubmitHandlers(): void {
- };
+ // The daemon owns submit and auto-templatizes detected secrets, so the
+ // manual template overrides don't apply; route through the daemon.
+ const summary = await submitServersViaDetectord(servers);
+ console.log(`[detectord] onboarding submit (templates ignored; daemon auto-templatizes): ${summary.submitted} submitted, ${summary.failures.length} failed`);
+ return summary;
</file context>
There was a problem hiding this comment.
All reported issues were addressed across 9 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
1 participant
Summary by cubic
Moved all file-system detection and quarantine logic out of the Electron client. The
detectorddaemon now owns discovery, hook install, and quarantine; the client only reads status and routes submissions via the daemon. Also fixed multi-server dedup and credential template forwarding (including empty submissions).Refactors
hookInjectionto report status only.mcp:injectHooks/mcp:removeHooks, andmcp:injectVsCodeWorkspaceHook/mcp:removeVsCodeWorkspaceHook; ClientsView now just refreshes status.submit_config; handled empty template submits; SSE handler optional-safe.chokidardependency.Migration
window.api.mcp.injectHooks(),window.api.mcp.removeHooks(),window.api.mcp.injectVsCodeWorkspaceHook(), andwindow.api.mcp.removeVsCodeWorkspaceHook().getHookStatus()to display current state; installation is daemon-managed.EW_DETECTORD_PRIMARYtoggle is removed).Written for commit 8e4ed2e. Summary will update on new commits.