Skip to content

fix(mariadb): disable binary logs by default#342

Open
mrrobot47 wants to merge 1 commit into
EasyEngine:developfrom
mrrobot47:fix/disable-mariadb-binlogs
Open

fix(mariadb): disable binary logs by default#342
mrrobot47 wants to merge 1 commit into
EasyEngine:developfrom
mrrobot47:fix/disable-mariadb-binlogs

Conversation

@mrrobot47

Copy link
Copy Markdown
Member

Summary

  • Disable MariaDB binary logging by default in the EasyEngine MariaDB image.
  • Remove the default log_bin, log_bin_index, binlog_format, expire_logs_days, and max_binlog_size settings from mariadb/ee.cnf.
  • Keep the [mysqld] section so the config file remains valid.

Why

EasyEngine does not configure or manage MariaDB replication for the global DB. Enabling binary logs by default causes persisted mariadb-bin.* files to grow without a practical total disk cap.

max_binlog_size only rotates individual files, and expire_logs_days only purges by age during specific server events. High-write installs can still fill disk.

Notes

skip-log-bin is intentionally not added. Removing EasyEngine's default log_bin keeps binlogging off by default without overriding users who deliberately enable binlogs elsewhere.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables MariaDB binary logging by default in the EasyEngine MariaDB image by removing EasyEngine’s explicit binlog configuration from mariadb/ee.cnf, preventing unbounded growth of persisted mariadb-bin.* files on non-replication installs.

Changes:

  • Removed log_bin, log_bin_index, binlog_format, expire_logs_days, and max_binlog_size defaults from mariadb/ee.cnf.
  • Kept the [mysqld] section so the config file remains syntactically valid.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants