Add Boox MyScript handwriting recognition with ML Kit fallback - #7
Open
imedwei wants to merge 6 commits into
Open
Add Boox MyScript handwriting recognition with ML Kit fallback#7imedwei wants to merge 6 commits into
imedwei wants to merge 6 commits into
Conversation
imedwei
force-pushed
the
feature/myscript-hwr
branch
from
March 21, 2026 13:14
11b1628 to
75d14ac
Compare
Scripts (review-pr.sh, review-check.sh) run Claude Code reviews locally against the branch diff, with --local/--post/--no-post flags for non-interactive agent use. Uses printf-based prompt passing to avoid shell injection from diff content. Includes iterative review-fix-verify cycle in CLAUDE.md PR workflow. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use TypedValue.applyDimension for SP to pixel conversions instead of the deprecated DisplayMetrics.scaledDensity field. Extract initLayout() and computeTextSizes() for clearer separation of layout vs text sizing. Add type-safe TestLogEvent, replace KotlinClosure2 with TestListener, and add allTests task with test ordering. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace blanket finger rejection in both views with a shared TouchFilter that applies five palm-rejection layers (pen-active suppression, 150ms cooldown, touch-size threshold, multi-touch rejection, stationary timeout). Canvas allows finger vertical scroll; text view allows finger taps on logo/text and finger scroll. All stylus gestures unchanged. Fixes #4 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace the permanent ~69dp side gutter with lighter UI elements. The "I" logo is now a floating icon in the top-right of the text view that auto-hides during writing (300ms delay on pen lift). Split resize is handled by dragging the 1dp divider with an expanded touch target. Text view scroll drives canvas scroll so the two views stay complementary — preview shows recognized content, canvas shows what hasn't been recognized yet. Diagrams render progressively as they scroll off, clipped to actual stroke bounds for flush alignment at the boundary. Only currently-hidden lines appear in preview text. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
imedwei
force-pushed
the
feature/myscript-hwr
branch
from
March 23, 2026 18:51
75d14ac to
68b12c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OnyxHwrTextRecognizerthat uses the Boox MyScript HWR service via AIDL for on-device handwriting recognitionTextRecognizerinterface withTextRecognizerFactorythat auto-detects Boox devices and falls back to Google ML KitTest plan
🤖 Generated with Claude Code