Kill orphaned listing processes on timeout (#4974)#4980
Merged
Conversation
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness and reliability of package listing operations by adding process tracking and timeout handling for package manager tasks. It ensures that any processes started during package listing are properly tracked and killed if a timeout occurs, preventing orphaned processes. Additionally, it allows individual package managers to opt out of automatic retries when timeouts can't be recovered, as done for Chocolatey.
Timeout and Process Management Improvements:
AsyncLocallist, and implemented logic to kill all registered processes if a listing task times out, preventing orphaned processes (PackageManager.cs).FindPackages,_getAvailableUpdates,_getInstalledPackages) to use a newRunListingTaskWithTimeouthelper, centralizing timeout and process cleanup logic (PackageManager.cs).Extensibility and Per-Manager Behavior:
RetryListingTasksOnTimeoutto allow package managers to specify whether listing tasks should be retried after a timeout. By default, retries are enabled, but individual managers can override this (PackageManager.cs).Chocolatey-specific Changes:
RetryListingTasksOnTimeoutin theChocolateymanager to returnfalse, disabling retries for Chocolatey listing tasks since fast repair is not possible in this context (Chocolatey.cs).RegisterListingProcessafter starting a process (Chocolatey.cs).