fix: use _PooledConnection wrapper instead of reassigning conn.close - #36
Merged
Conversation
conn.close is read-only in psycopg2, causing AttributeError and connections never returned to pool. Wrapper delegates to real connection and overrides close() to putconn() instead of closing. Co-authored-by: Cursor <cursoragent@cursor.com>
_PooledConnection had incorrectly absorbed Database methods. Restore correct structure: _PooledConnection only has close/__getattr__, Database has the rest. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes poller "connection pool exhausted" and
'psycopg2.extensions.connection' object attribute 'close' is read-onlyerrors.Problem
The code reassigned
conn.close = _closeso that callingclose()would return the connection to the pool instead of closing it. In psycopg2,conn.closeis read-only, causingAttributeErrorand connections never being returned to the pool.Solution
Introduce
_PooledConnectionwrapper that:__getattr__close()to callputconn()instead of closing the connectionDeploy
Requires new image build (e.g. v0.24) after merge.