fix: API OOM 137 - add /api/livez, connection pooling, close pool on shutdown - #33
Merged
Merged
Conversation
…shutdown - Add /api/livez lightweight liveness probe (no DB) for k8s liveness checks - Add DB connection pooling (ThreadedConnectionPool, 2-10 conns) to reduce connection churn and avoid exhaustion under load - Close connection pool on app/collector shutdown - Add tests for livez and health endpoints Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses API pods exiting with error 137 (SIGKILL) caused by liveness probe timeouts and potential OOM.
Changes
1. Lightweight liveness probe (
/api/livez)/api/livezendpoint that returns{"status": "ok"}without hitting the database/api/healthfor readiness (includes DB and upstream status)2. DB connection pooling
psycopg2.connect()withThreadedConnectionPool(min 2, max 10 connections)app_readonlylifespan) and collector shutdown (main.py)3. Tests
tests/test_app_readonly.pywith tests for/api/livezand/api/healthDeployment
Requires accompanying k8s changes in high-command-ui:
/api/livezRelated PR: DataKnifeAI/high-command-ui#23