Add poller secrets example manifest - #31
Merged
Merged
Conversation
The CI pipeline uses 'make build' but the Makefile didn't have a build target for Python projects. Error: make: *** No rule to make target 'build'. Stop. Changes: - Added build target that runs 'pip install --upgrade pip build' and 'python -m build' - Build depends on clean target to ensure fresh builds - Updated .PHONY declaration to include build - Updated help text to include build target
- Add poller-secrets-example.yaml with all poller environment variables - Includes instructions for creating the secret via kubectl - Documents all required secret keys for poller deployment Secret contains: - database-url: PostgreSQL connection string - helldivers-api-base: Hell Divers 2 API endpoint - helldivers-api-client-name: Client identifier - helldivers-api-contact: Contact information - scrape-interval: Data collection interval
- Change helldivers-api-contact from actual email to example value - Use 'your-email@example.com' as placeholder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds example Kubernetes Secret manifest for the High Command Poller service.
Changes
New File
k8s/poller-secrets-example.yaml- Example secret manifest with instructionsSecret Contents
The secret contains all sensitive environment variables for the poller:
database-url- PostgreSQL connection stringhelldivers-api-base- Hell Divers 2 API endpointhelldivers-api-client-name- Client identifierhelldivers-api-contact- Contact informationscrape-interval- Data collection interval (seconds)Usage
Create the secret using kubectl:
Related
This secret is used by the poller deployment (see
k8s/poller-deployment.yamlin the main k8s directory).