DO NOT MERGE - test the converting-agent PR against all system-tests - #7339
Draft
ajgajg1134 wants to merge 8 commits into
Draft
DO NOT MERGE - test the converting-agent PR against all system-tests#7339ajgajg1134 wants to merge 8 commits into
ajgajg1134 wants to merge 8 commits into
Conversation
Contributor
|
|
|
…de origin The trace agent's v1 conversion feature made three debugger test groups fail, all because the tests still assumed the legacy agent payload shape. Exception replay (java): a converted span carries a `_dd.convertedv1` provenance marker, and v0.4 `meta` values stay strings where a natively emitted v1 payload keeps real booleans. Drop the marker and canonicalize booleans on both sides of the approval comparison, so a single set of approval files stays valid whether or not conversion is enabled. Normalizing is preferred over re-recording the baselines, which would bake the current conversion path into them. Code origin (python): `_wait_for_code_origin_span` indexed the raw payload with legacy-only keys (`tracerPayloads`, `resource`, `type`, `meta`), so under v1 it never matched a span and timed out into a misleading "code origin not enabled" assertion. Iterate `interfaces.agent.get_spans()` instead, whose typed wrappers resolve those fields for both formats. Exception replay (php): the `*_spans_expected_v1.json` approvals were never generated, so the tests raised FileNotFoundError. Recorded them with DI_OVERRIDE_APPROVALS so they land in the existing 1.18.0 folder alongside the legacy files, rather than in a new version folder. Validated locally per language with the converting agent and with the default agent, confirming the payload format in each run via the captured agent interface files: java/spring-boot DEBUGGER_EXCEPTION_REPLAY 8 passed both ways python/flask-poc DEBUGGER_INPRODUCT_ENABLEMENT 5 passed both ways php/apache-mod-8.0 DEBUGGER_EXCEPTION_REPLAY 9 passed both ways Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Re-run CI after widespread SSI matrix and PHP e2e job failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present