Skip to content

Remove v1 user-creation path#640

Open
michael-richey wants to merge 1 commit into
add-saml-nameid-handle-flagfrom
remove-v1-user-api-flag
Open

Remove v1 user-creation path#640
michael-richey wants to merge 1 commit into
add-saml-nameid-handle-flagfrom
remove-v1-user-api-flag

Conversation

@michael-richey

@michael-richey michael-richey commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Stacked on #639. Remove the legacy v1 user-creation implementation now that compatible destination APIs can receive an explicit handle through the v2 path.

Breaking change

--use-v1-user-api and DD_USE_V1_USER_API no longer select a v1 execution path. They remain recognized only so existing command lines, environment settings, and configuration files fail fast with migration guidance instead of silently reverting to default v2 behavior.

Operators should either:

  • Switch to --preserve-user-handle / DD_PRESERVE_USER_HANDLE when the destination supports explicit handles during user creation, or
  • Pin to an older version if the legacy v1 path is still required.

Changes

  • Remove the v1 create branch and its post-create lookup helpers.
  • Remove the runtime use_v1_user_api configuration field.
  • Keep the old option and environment variable hidden as compatibility guards that raise a usage error when enabled.
  • Remove the v1 README section and implementation-specific tests.
  • Add regression tests for direct configuration, CLI, and environment-variable failure paths.

Test plan

  • Red/green tests confirm legacy settings fail before API or storage work
  • sync --help and migrate --help show --preserve-user-handle and hide the removed option
  • Full Python 3.11 unit suite passes

@michael-richey
michael-richey marked this pull request as ready for review July 24, 2026 20:25
@michael-richey
michael-richey requested a review from a team as a code owner July 24, 2026 20:25
@michael-richey michael-richey changed the title Remove --use-v1-user-api flag and v1 user-creation path Remove v1 user-creation path Jul 24, 2026
Use the v2 user-creation path for all new users and remove the legacy v1 implementation. Retain hidden parsing for the removed option and environment variable so existing configurations fail fast with migration guidance instead of silently changing behavior.
@michael-richey
michael-richey force-pushed the add-saml-nameid-handle-flag branch from be63b9b to 8627230 Compare July 24, 2026 21:31
@michael-richey
michael-richey force-pushed the remove-v1-user-api-flag branch from 23117f1 to 8ebf9d9 Compare July 24, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant