chore: make integration tests local - #804
Conversation
Remove the cold_start value normalization from the local harness pipeline. The cold->warm transition (invoke #1 cold_start:true, invokes #2..N false) is deliberate coverage and is deterministic locally, since proactive initialization cannot happen unless SIMULATE_PROACTIVE_INIT=true. Snapshots regenerated with real cold_start values. proactive_initialization markers and the '(init: N ms)' END suffix remain stripped: they reflect platform scheduling, not code behavior. The real-AWS run_integration_tests.sh is intentionally untouched; proactive-init cold_start flakes there are handled by rerun.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0df937ad33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Download the RIE binary once into ./bin (gitignored). | ||
| rie_binary="$local_dir/bin/aws-lambda-rie" | ||
| if [ ! -f "$rie_binary" ]; then |
There was a problem hiding this comment.
When a developer follows the README and switches PLATFORM after a first run, this always reuses bin/aws-lambda-rie if it already exists, regardless of whether it was downloaded as the arm64 or x86_64 asset. The mounted binary is executed inside the --platform "$PLATFORM" container, so the second platform run can start with the wrong-architecture RIE binary and fail before the port becomes ready; include the platform in the cached filename or re-download when the requested platform changes.
Useful? React with 👍 / 👎.
|
Adds a workflow that runs the RIE-based harness from integration_tests_local/ on every PR and main push: one job per Node major version (18/20/22/24), each building and testing both container variants against the real AWS Lambda base images. No AWS credentials needed. Uses linux/amd64 images on the x86_64 runners.
1 participant
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply