Readme & tasks 1,2, 4, 5 by AldMatvey · Pull Request #6 · DafeMipt213/algorithms_2nd

AldMatvey · 2023-11-26T21:21:08Z

No description provided.

LostPointer · 2023-11-27T15:17:34Z

Доки по программе в отдельным ПРом нужно делать

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 98. Check the log or trigger a new build to see more.

github-actions · 2023-12-23T08:58:56Z


-TEST(Template, Simple) { ASSERT_EQ(true, true); }
+TEST(Template, Easy) { 
+    std::vector<int> vec{1, 10, 7, 6, 3, 2, 1, 11};


warning: variable 'vec' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<int> vec{1, 10, 7, 6, 3, 2, 1, 11};

std::vector<int> vec = 0{1, 10, 7, 6, 3, 2, 1, 11};

github-actions · 2023-12-23T08:58:57Z

+    ASSERT_EQ(rmq.findMin(1, 7), 1); 
+    }
+TEST(Template, Medium) { 
+    std::vector<int> vec{1, 10, 7, 6, 3, 2, 1, 11};


warning: variable 'vec' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<int> vec{1, 10, 7, 6, 3, 2, 1, 11};

std::vector<int> vec = 0{1, 10, 7, 6, 3, 2, 1, 11};

github-actions · 2023-12-23T08:58:57Z

+    ASSERT_EQ(rmq.findMin(6, 7), 1); 
+    }
+TEST(Template, Hard) { 
+    std::vector<int> vec{1, 10, 7, 6, 3, 2, 1, 11};


warning: variable 'vec' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<int> vec{1, 10, 7, 6, 3, 2, 1, 11};

std::vector<int> vec = 0{1, 10, 7, 6, 3, 2, 1, 11};

github-actions · 2023-12-23T08:58:57Z

+    ASSERT_EQ(rmq.findMin(3, 4), 3); 
+    }
+TEST(Template, Harder) { 
+    std::vector<int> vec{1, 10, 7, 6, 3, 2, 1, 11, 12};


warning: variable 'vec' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<int> vec{1, 10, 7, 6, 3, 2, 1, 11, 12};

std::vector<int> vec = 0{1, 10, 7, 6, 3, 2, 1, 11, 12};

github-actions · 2023-12-23T08:58:57Z

+    ASSERT_EQ(rmq.findMin(7, 8), 11); 
+    }
+TEST(Template, Comlicated) {
+    std::vector<int> vec{1, 10, 7, 6, 3, 2, 1, 11, 12, 1, 1, 1};


warning: variable 'vec' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<int> vec{1, 10, 7, 6, 3, 2, 1, 11, 12, 1, 1, 1};

std::vector<int> vec = 0{1, 10, 7, 6, 3, 2, 1, 11, 12, 1, 1, 1};

github-actions · 2023-12-23T08:58:59Z

+  ASSERT_EQ(graph.topologySort(0), res);
+}
+TEST(TopologySort, Comlex) {
+  std::vector<std::vector<int>> input = {{1, 2}, {3}, {3, 4}, {1, 4}, {0}, {}, {7, 8}, {10}, {9, 10}, {6, 11}, {7}, {}, {9, 10, 11}};


warning: variable 'input' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<std::vector<int>> input = {{1, 2}, {3}, {3, 4}, {1, 4}, {0}, {}, {7, 8}, {10}, {9, 10}, {6, 11}, {7}, {}, {9, 10, 11}};

std::vector<std::vector<int>> input = 0 = {{1, 2}, {3}, {3, 4}, {1, 4}, {0}, {}, {7, 8}, {10}, {9, 10}, {6, 11}, {7}, {}, {9, 10, 11}};

github-actions · 2023-12-23T08:58:59Z

+TEST(TopologySort, Comlex) {
+  std::vector<std::vector<int>> input = {{1, 2}, {3}, {3, 4}, {1, 4}, {0}, {}, {7, 8}, {10}, {9, 10}, {6, 11}, {7}, {}, {9, 10, 11}};
+  Graph graph(input);
+  std::vector<int> res = {5, 12, 9, 11, 6, 8, 7, 10, 0, 2, 1, 3, 4};


warning: variable 'res' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<int> res = {5, 12, 9, 11, 6, 8, 7, 10, 0, 2, 1, 3, 4};

std::vector<int> res = 0 = {5, 12, 9, 11, 6, 8, 7, 10, 0, 2, 1, 3, 4};

github-actions · 2023-12-23T08:58:59Z

+}
+
+TEST(TopologySort, Empty) {
+  std::vector<std::vector<int>> input = {{0}};


warning: variable 'input' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<std::vector<int>> input = {{0}};

std::vector<std::vector<int>> input = 0 = {{0}};

github-actions · 2023-12-23T08:58:59Z

+TEST(TopologySort, Empty) {
+  std::vector<std::vector<int>> input = {{0}};
+  Graph graph(input);
+  std::vector<int> res = {0};


warning: variable 'res' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<int> res = {0};

std::vector<int> res = 0 = {0};

github-actions · 2023-12-23T08:58:59Z

+}
+
+TEST(TopologySort, FullGraphLoops) {
+  std::vector<std::vector<int>> input = {{0, 1, 2, 3, 4}, {0, 1, 2, 3, 4}, {0, 1, 2, 3, 4}, {0, 1, 2, 3, 4}, {0, 1, 2, 3, 4}};


warning: variable 'input' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<std::vector<int>> input = {{0, 1, 2, 3, 4}, {0, 1, 2, 3, 4}, {0, 1, 2, 3, 4}, {0, 1, 2, 3, 4}, {0, 1, 2, 3, 4}};

std::vector<std::vector<int>> input = 0 = {{0, 1, 2, 3, 4}, {0, 1, 2, 3, 4}, {0, 1, 2, 3, 4}, {0, 1, 2, 3, 4}, {0, 1, 2, 3, 4}};

fixes

github-actions

clang-tidy made some suggestions

github-actions · 2023-12-23T09:23:25Z

+    {
+        if(colors[i] == 0)
+        {
+            still_white = i;


warning: narrowing conversion from 'size_t' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

still_white = i; ^

github-actions · 2023-12-23T09:23:26Z

+
+Graph::Graph(std::vector<std::vector<int>> new_graph)
+{
+    graph_list = new_graph;


warning: 'graph_list' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

task_01/src/topology_sort.cpp:63:

- Graph::Graph(std::vector<std::vector<int>> new_graph) + Graph::Graph(std::vector<std::vector<int>> new_graph) : graph_list(new_graph)

Suggested change

graph_list = new_graph;

github-actions · 2023-12-23T09:23:26Z

+
+Graph::Graph(std::vector<std::vector<int>> new_graph)
+{
+    graph_list = new_graph;


warning: parameter 'new_graph' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]

graph_list = new_graph; ^

this fix will not be applied because it overlaps with another fix

github-actions · 2023-12-23T09:23:26Z

+Graph::Graph(std::vector<std::vector<int>> new_graph)
+{
+    graph_list = new_graph;
+    timer = 0;


warning: 'timer' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]

task_01/src/topology_sort.cpp:63:

- Graph::Graph(std::vector<std::vector<int>> new_graph) + Graph::Graph(std::vector<std::vector<int>> new_graph), timer(0)

Suggested change

timer = 0;

github-actions · 2023-12-23T09:23:26Z

+}
+
+std::set<std::pair<int, int>> findBridges (const std::vector<std::vector<int>>& graph){
+  int time = 0;


warning: variable 'time' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int time = 0;

int const time = 0;

github-actions · 2023-12-23T09:23:27Z

+    size_t pow_len = std::pow(2,  pow);
+    minimum_table.push_back(input_vector);
+    minimum_table[0].resize(pow_len, __INT_MAX__);
+    int current_pow = pow - 1;


warning: Value stored to 'current_pow' during its initialization is never read [clang-analyzer-deadcode.DeadStores]

int current_pow = pow - 1; ^

Additional context

task_05/src/RMQ.cpp:9: Value stored to 'current_pow' during its initialization is never read

int current_pow = pow - 1; ^

github-actions · 2023-12-23T09:23:27Z

+    size_t pow_len = std::pow(2,  pow);
+    minimum_table.push_back(input_vector);
+    minimum_table[0].resize(pow_len, __INT_MAX__);
+    int current_pow = pow - 1;


warning: narrowing conversion from 'size_t' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

int current_pow = pow - 1; ^

github-actions · 2023-12-23T09:23:27Z

+int RMQ::findMin(const unsigned int left, const unsigned int right){
+    if(left > right || left < 0 || right > minimum_table[0].size()) 
+        throw std::out_of_range ("wrong border arguments");
+    size_t row = std::floor(std::log2(right - left + 1));


warning: variable 'row' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness]

Suggested change

size_t row = std::floor(std::log2(right - left + 1));

size_t const row = std::floor(std::log2(right - left + 1));

github-actions · 2023-12-23T09:23:27Z

+    if(left > right || left < 0 || right > minimum_table[0].size()) 
+        throw std::out_of_range ("wrong border arguments");
+    size_t row = std::floor(std::log2(right - left + 1));
+    return std::min(minimum_table[row][left], minimum_table[row][right - std::pow(2, row) + 1]);


warning: narrowing conversion from 'typename __gnu_cxx::__promote_2<int, unsigned long>::__type' (aka 'double') to 'size_type' (aka 'unsigned long') [cppcoreguidelines-narrowing-conversions]

return std::min(minimum_table[row][left], minimum_table[row][right - std::pow(2, row) + 1]); ^

github-actions · 2023-12-23T09:23:28Z

@@ -1,6 +1,72 @@

 #include <gtest/gtest.h>


warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]

#include <gtest/gtest.h> ^

AldMatvey added 8 commits November 18, 2023 10:32

task 3 done

227b6fd

task 2 completed + renamed files

b427324

added more tests for topology_sort

6ceac89

Merge branch 'DafeMipt213:main' into main

4fb8fa2

task 4 and 5

6ff683c

added more tests for RMQ

5d4a70e

added the list of theory to readme

923358b

Merge branch 'main' into main

74ac235

Merge branch 'DafeMipt213:main' into main

ac366be

github-actions Bot reviewed Dec 23, 2023

View reviewed changes

Merge pull request #1 from DafeMipt213/main

459f1f1

fixes

github-actions Bot reviewed Dec 23, 2023

View reviewed changes

	std::vector<int> vec{1, 10, 7, 6, 3, 2, 1, 11};
	std::vector<int> vec = 0{1, 10, 7, 6, 3, 2, 1, 11};

	std::vector<std::vector<int>> input = {{1, 2}, {3}, {3, 4}, {1, 4}, {0}, {}, {7, 8}, {10}, {9, 10}, {6, 11}, {7}, {}, {9, 10, 11}};
	std::vector<std::vector<int>> input = 0 = {{1, 2}, {3}, {3, 4}, {1, 4}, {0}, {}, {7, 8}, {10}, {9, 10}, {6, 11}, {7}, {}, {9, 10, 11}};

	std::vector<int> res = {5, 12, 9, 11, 6, 8, 7, 10, 0, 2, 1, 3, 4};
	std::vector<int> res = 0 = {5, 12, 9, 11, 6, 8, 7, 10, 0, 2, 1, 3, 4};

	size_t row = std::floor(std::log2(right - left + 1));
	size_t const row = std::floor(std::log2(right - left + 1));

Uh oh!

Conversation

AldMatvey commented Nov 26, 2023

Uh oh!

LostPointer commented Nov 27, 2023

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Dec 23, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants