external_deps: add download action to download and extract the external deps tarball like CMake#1985
Open
illwieckz wants to merge 2 commits into
Open
external_deps: add download action to download and extract the external deps tarball like CMake#1985illwieckz wants to merge 2 commits into
illwieckz wants to merge 2 commits into
Conversation
…al deps tarball like CMake
illwieckz
force-pushed
the
illwieckz/download-deps
branch
from
3ef92aa to
1e2392b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
downloadaction to download and extract the external deps tarball like CMake.Allows to do:
It would download https://dl.unvanquished.net/deps/macos-amd64-default_11.tar.xz and extract it as
external_deps/macos-amd64-default_11.The reason why I'm doing this is that I'm upgrading the docker-based release scripts to use a newer Darling version (in hope I can install a newer XCode supporting arm64) and there is a regression in the latest version of Darling: everything works but the CMake builtin download. CMake probably uses an buggy library/feature that curl doesn't.
By downloading and extracting the deps before calling CMake, everything works.
Implementing it in
external_deps/build.shensures the version, directory name, etc. are always correct.