ci: add a compile-check workflow for REFORK and its feature branches#27
Merged
Conversation
Nothing in this fork can build without jniLibs.zip (this repo's own README: download it separately from Cateners/tiny_container's releases and extract to app/src/main/jniLibs/arm64-v8a) — that download is step one here, not an afterthought, since without it every build fails before touching any of this fork's own code. This is compile-only: no signing, no emulator/device, no instrumented tests — it exists to catch the class of bug most likely in hand-written code that never saw a compiler (Kotlin syntax errors, missing imports, View Binding class/id mismatches, resource reference typos), which is exactly the risk profile of PR #25 and #26. Deliberately did not pin specific SDK platform/build-tools/NDK package versions — this is bleeding-edge tooling (AGP 9.2.1, compileSdk 37) and a wrong guessed version string would fail the workflow for environment reasons unrelated to the actual code. Accepting SDK licenses is enough for AGP to auto-provision whatever it actually needs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
DaRipper91
pushed a commit
that referenced
this pull request
Jul 21, 2026
CI (#27) caught two things on this branch's original ProotExec.kt: 1. A genuine compile error: the KDoc comment's own text contained the literal sequence "PROOT_LOADER*/PROOT_TMP_DIR" — the `*/` inside that prose prematurely closed the doc comment, so everything after it (the rest of the comment, then the real code) got parsed as top-level Kotlin and failed with cascading "Expecting a top level declaration" syntax errors starting at that exact line/column. 2. The underlying proot flags this file guessed at (-r/-w/-b, no --change-id, no proc/sys placeholder files) were also substantively wrong, not just wrapped in a comment with a syntax bug. This was already found and fixed while building PR #26's UI (which needed to actually invoke this to synthesize a working boot_command) by locating tiny-computer/images' real, live proot-distro.tiny.yaml — but the fix only landed on #26's branch, never backported here, which is why CI still caught the old broken version on this one. Pulling over the already-corrected files as-is from #26 rather than re-deriving them: ProotExec.kt (runAsRootCommand/bootCommandTemplate replacing the old runInContainerCommand, using the real verified flags), DistroInstaller.kt (creates the proc/sys placeholder files those real flags' bind mounts require, in a second shell session after extraction completes), DeInstaller.kt (updated call site). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
DaRipper91
pushed a commit
that referenced
this pull request
Jul 21, 2026
CI (#27) caught this: showFragmentForScreen()'s new Screen.DistroSelect/ DeSelect cases referenced these classes without importing them. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a compile-only CI check that runs on PRs/pushes against
REFORKand anyrefork/**branch — including #25 and #26, which currently have zero compiler feedback on ~900+ lines of hand-written Kotlin/XML.What it does
jniLibs.zipfromCateners/tiny_container's latest release (required for any build in this repo at all, per its own README — verified this asset exists and the.../releases/latest/download/jniLibs.zipredirect works)./gradlew assembleDebugWhat it does NOT do
No signing, no emulator/device, no instrumented tests. This only proves the code compiles — a real device test is still needed before merging #25/#26 regardless of whether this goes green.
🤖 Generated with Claude Code