Skip to content

Feature: boundary condition handler MPI communication - #2408

Draft
sandro-elsweijer wants to merge 11 commits into
feature-boundary_condition_managerfrom
feature-boundary_condition_manager_2
Draft

Feature: boundary condition handler MPI communication#2408
sandro-elsweijer wants to merge 11 commits into
feature-boundary_condition_managerfrom
feature-boundary_condition_manager_2

Conversation

@sandro-elsweijer

Copy link
Copy Markdown
Member

Describe your changes here:
The boundary condition handler implemented in #2401 only works for new cmeshes which are created equally on all processes.
This PR introduces a bcast and synchronize function, which can be used for t8_cmesh_bcast or for partitioned cmeshes.
Closes #2405

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • README.md files are updated if necessary.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the scripts/internal/find_all_source_files.sh to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@sandro-elsweijer sandro-elsweijer changed the title Feature: boundary condition manager 2 Feature: boundary condition handler MPI communication Aug 21, 2026
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.17949% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.55%. Comparing base (b914808) to head (844babb).

Files with missing lines Patch % Lines
...s/internal/t8_cmesh_boundary_condition_handler.hxx 76.92% 6 Missing ⚠️
...s/internal/t8_cmesh_boundary_condition_handler.cxx 95.83% 2 Missing ⚠️
src/t8_cmesh/t8_cmesh_internal/t8_cmesh_commit.cxx 50.00% 2 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           feature-boundary_condition_manager    #2408      +/-   ##
======================================================================
+ Coverage                               82.54%   82.55%   +0.01%     
======================================================================
  Files                                     132      132              
  Lines                                   20998    21073      +75     
======================================================================
+ Hits                                    17332    17397      +65     
- Misses                                   3666     3676      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activate boundary conditions for broadcasted, derived, etc. cmeshes.

1 participant