feat(editor): add TypeScript script tooling - #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Site script authors currently get syntax highlighting and publish-time compilation, but not the semantic editing feedback expected from TypeScript tooling. This addresses the workflow requested in Discussion #351 while keeping esbuild as the authoritative canvas and publish compiler.
User impact
Authors receive type errors, DOM API suggestions, signatures, and cross-file type information directly in the Code tab. The language service loads only when a TypeScript script is opened and runs off the UI thread. Large diagnostic sets remain bounded and can collapse to their error count.
Verification
bun test ./src/__tests__/admin/siteItemNames.test.ts ./src/__tests__/architecture/typescript-language-worker-isolation.test.ts ./src/__tests__/architecture/bundle-size-budgets.test.ts ./src/__tests__/code-editor/codeMirrorEditor.test.tsx ./src/__tests__/code-editor/scriptSettingsPane.test.tsx ./src/__tests__/code-editor/typescriptLanguageService.test.tsbun run lintbun run buildgit diff --check