Fix WordPress URLs in the Figma sandbox - #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
URLconstructor usage from the Figma main-thread bundleURLconstructor callsRoot cause
Figma runs main plugin code in a minimal JavaScript sandbox without normal browser APIs. The WordPress key was valid, but
new URL(...)threw inside that sandbox. The parser caught the runtime error and mislabeled it as an invalid connection key. The same browser-only constructor was also present in the subsequent synchronization request path.Validation
globalThis.URLremovedbun run build:figmabun run release:figma -- 2.0.0dist/code.jscontains noURLconstructor usage