⚡ Bolt: [performance improvement] Remove intermediate array allocation in uniqueBusinessGroupId#613
Conversation
…n in uniqueBusinessGroupId
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head47e9a00715474ef047a827a49a32d60657a7270f. -
Head SHA:
47e9a00715474ef047a827a49a32d60657a7270f -
Workflow run: 29881129740
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: bolt.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: bolt.md"]
R1 --> V1["required checks"]
Evidence --> S2["Frontend: businessGroups.ts"]
S2 --> I2["browser runtime and bundle"]
I2 --> R2["Review risk: Frontend: businessGroups.ts"]
R2 --> V2["frontend tests"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: bolt.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: bolt.md"]
R1 --> V1["required checks"]
Evidence --> S2["Frontend: businessGroups.ts"]
S2 --> I2["browser runtime and bundle"]
I2 --> R2["Review risk: Frontend: businessGroups.ts"]
R2 --> V2["frontend tests"]
|
💡 What:
uniqueBusinessGroupId함수에서new Set(existingGroups.map(...))패턴을 제거하고for...of루프를 사용하여 Set을 채우도록 변경했습니다.🎯 Why:
기존 방식은
.map()을 호출할 때마다 새로운 중간 배열을 생성하여 가비지 컬렉터(GC)에 불필요한 부하를 주었습니다. 이는 React 애플리케이션의 렌더링 성능 저하(jank)를 유발할 수 있습니다.📊 Impact:
중간 배열 할당으로 인한 O(N) GC 오버헤드를 제거하여, 그룹 할당과 같은 작업 시 메모리 사용량을 줄이고 실행 속도를 미세하게 개선했습니다.
🔬 Measurement:
frontend/src/erd/__tests__/businessGroups.test.ts테스트가 모두 정상적으로 통과하는 것을 확인했습니다 (pnpm test). 메모리 할당 프로파일러를 통해 배열 생성이 줄어든 것을 확인할 수 있습니다.PR created automatically by Jules for task 16944190678593806605 started by @seonghobae