π¨ Palette: λΉ λλ ν 리 μν λ©μμ§μ μ κ·Όμ± κ°μ μΆκ°#245
π¨ Palette: λΉ λλ ν 리 μν λ©μμ§μ μ κ·Όμ± κ°μ μΆκ°#245seonghobae wants to merge 1 commit into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR improves the accessibility of html4treeβs generated directory listing HTML by marking the empty-directory message as a status message for assistive technologies.
Changes:
- Add
role="status"to the empty-directory message element in generatedindex.html. - Update
MainTest.testGoEmptyDirto check for the newrole="status"attribute. - Record the accessibility learning/action in
.jules/palette.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/kotlin/html4tree/main.kt | Adds role="status" to the empty-directory message markup. |
| src/test/kotlin/html4tree/MainTest.kt | Adds an assertion to verify the presence of role="status" in generated HTML. |
| .jules/palette.md | Documents the accessibility improvement as a Palette learning/action entry. |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| assertTrue(htmlContent.contains("<html lang=\"ko\">")) | ||
| assertTrue(htmlContent.contains("μ΄ λλ ν 리λ λΉμ΄ μμ΅λλ€.")) | ||
| assertTrue(htmlContent.contains("role=\"list\"")) | ||
| assertTrue(htmlContent.contains("role=\"status\"")) |
π‘ What: λΉ λλ ν 리 μνλ₯Ό λνλ΄λ
<div>μμμrole="status"ARIA μμ±μ μΆκ°νμ΅λλ€.π― Why: μ€ν¬λ¦° 리λ μ¬μ©μκ° μκ°μ μΌλ‘ λΉμ΄ μμμ λνλ΄λ ν μ€νΈλ₯Ό μΈμ§νκΈ° μ΄λ ΅κΈ° λλ¬Έμ μν λ©μμ§λ₯Ό λͺ νν μ λ¬νκΈ° μν¨μ λλ€.
πΈ Before/After:
<div class="empty-dir">...</div>-><div class="empty-dir" role="status">...</div>βΏ Accessibility: μ μ HTMLμμλ μν λ©μμ§μ
role="status"λ₯Ό λΆμ¬νμ¬ μ κ·Όμ±μ ν₯μμμΌ°μ΅λλ€.PR created automatically by Jules for task 572414385812584952 started by @seonghobae