fix(communications): load templates client-side with graceful API failures - #301
Merged
Merged
Conversation
This was referenced Jul 31, 2026
kkopanidis
previously approved these changes
Jul 31, 2026
…lures Move email and unified template fetching off the server render path so GET /email/templates failures on remote environments show inline errors instead of a redacted Module Error boundary crash.
Carry list filter/pagination state via a `list` query param on model detail URLs so the in-app back button restores owner, page, and search filters.
CluelessBiker
force-pushed
the
fix/communications-templates-prod-error
branch
from
August 3, 2026 05:11
d7545b5 to
31913be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/communications/testand/communications/templates.GET /email/templatesfails, instead of crashing into the redacted Module Error boundary.owner,page,search).Why
On experimental.dev, both pages failed during server-side
getTemplates()while other communications routes worked. The same UI works locally, so the failure is environment-specific. Client-side fetching surfaces actionable errors in production and keeps SMS, push, and email-only flows usable when template APIs are down.Separately, the models list already stored filters in the URL, but navigating into a model detail and clicking Models always returned to the unfiltered list. List state is now carried via a
listquery param on the detail URL and restored on back navigation.Related PR
Test plan
/communications/testand/communications/templateson localhost — both load normally./database/models?owner=database&page=2, open a model, then click Models — returns to the filtered, paginated list.listparam persists; back still restores the original list state.listparam remains in the URL.