chore(deps): take @conduction/nextcloud-vue 2.8.2 (was 2.8.0) - #2622
Merged
Conversation
Two user-visible defects are fixed by this bump. TWO AI-COMPANION HEXES ON EVERY PAGE. The companion singleton landed in 2.7.0. Below that the host app's own companion never stands down, so any page of this app rendered a second hex 8px from hermiq's — measured on a running instance: openconnector (2.7.1) showed ONE, openbuild (2.6.3) showed TWO, both visible at 52x60, from two separate mounts. THE DETAIL PAGE RECLOSED ITS SIDEBAR WHILE HYDRATING. CnDetailPage set sidebarSeeded and never read it, so 'open' was re-applied on every sync and each reactive change during hydration reset it to the prop default. Fixed in nextcloud-vue#711; that is the cause behind openbuild#268 and, on the evidence, #188. Lockfile only — the existing caret already allowed this. Three-line diff (version, resolved, integrity).
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 175/175 | |||
| npm | ✅ | ✅ 528/528 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-20 11:13 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lockfile-only bump of
@conduction/nextcloud-vueto 2.8.2. The existing caret already allowed it — as with hydra-gates, it was the lockfile doing the pinning, not the constraint. Three-line diff: version, resolved, integrity.Two user-visible defects are fixed by it.
1. Two AI-companion hexes on every page
The companion singleton landed in 2.7.0. Below that, the host app's own companion never stands down, so hermiq's page-wide companion renders alongside it. Measured on a running instance this morning:
.cn-ai-floating-button/apps/openconnector//apps/openbuild/They are two separate mounts, not one duplicated:
window.__cnAiCompanionPrimarywas claimed and both still rendereddisplay:flex / visible / opacity:1, well past the 1200 msLEGACY_SIBLING_DELAY— the negotiation works between two 2.7.x instances and fails when the host copy predates it.2. The detail page reclosed its own sidebar while hydrating
CnDetailPage.syncSidebarState()documented the rule — "Seedopenonly on the inactive→active edge … Subsequent syncs must NOT clobber it" — but setsidebarSeededand never read it, soopenwas re-applied on every sync. A detail page emits several while it hydrates, and each resetopento the prop default offalse.Fixed in ConductionNL/nextcloud-vue#711, with three regression tests written against the unfixed component first (the key one failed: expected
true, receivedfalse). Full library suite after the fix: 535 suites, 6408 tests, all passing.That is the cause behind ConductionNL/openbuild#268 (
.ob-icon-section"resolves 30×, hidden") and, on the same signature, #188.Verification
CI on this PR is the gate — in particular each app's own e2e suite.
npm update … --package-lock-onlywas used so nothing but the lock moves.