Skip to content

feat(rendering): skyline based effect placement #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Danielku15 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(rendering): skyline based effect placement #2750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
10 changes: 7 additions & 3 deletions packages/alphatab/src/DisplaySettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,12 +319,16 @@ export class DisplaySettings {
public staffPaddingLeft: number = 2;

/**
* The padding between individual effect bands.
* Clearance applied around each effect band on its staff-facing side:
* "bottom padding" for top bands (between the band and the staff or
* the band stacked below it) and "top padding" for bottom bands
* (mirrored). Also used as the inter-band gap when bands stack on
* the same side.
* @since 1.7.0
* @category Display
* @defaultValue `2`
* @defaultValue `5`
*/
public effectBandPaddingBottom = 2;
public effectBandPaddingBottom = 5;

/**
* The additional padding to apply between the staves of two separate tracks.
Expand Down
8 changes: 6 additions & 2 deletions packages/alphatab/src/generated/DisplaySettingsJson.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,10 +279,14 @@ export interface DisplaySettingsJson {
*/
staffPaddingLeft?: number;
/**
* The padding between individual effect bands.
* Clearance applied around each effect band on its staff-facing side:
* "bottom padding" for top bands (between the band and the staff or
* the band stacked below it) and "top padding" for bottom bands
* (mirrored). Also used as the inter-band gap when bands stack on
* the same side.
* @since 1.7.0
* @category Display
* @defaultValue `2`
* @defaultValue `5`
*/
effectBandPaddingBottom?: number;
/**
Expand Down
Loading
Loading