Skip to content

first stab at excluding content from size prop#3378

Draft
LinKCoding wants to merge 1 commit into
mainfrom
kl-datagrid-column-size
Draft

first stab at excluding content from size prop#3378
LinKCoding wants to merge 1 commit into
mainfrom
kl-datagrid-column-size

Conversation

@LinKCoding

Copy link
Copy Markdown
Contributor

Overview

Restricts ColumnConfig.size so consumers of DataGrid, DataTable, and DataList can no longer set size: 'content' on column definitions — that value remains reserved for internal control columns (e.g. select/expand).

  • Updates ColumnConfig.size in packages/gamut/src/DataList/types.ts from ListColProps['size'] to Exclude<ListColProps['size'], 'content'>
  • sm, md, lg, and xl column sizes remain available
  • Adds commented-out type-check snippets in DataTable.tsx and DataList.tsx for local verification

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. See that tests pass.
  2. Go to DataList.tsx and/or DataTable.tsx
  3. Uncomment the TestingDataTable or TestingDataList snippet in packages/gamut/src/DataList/DataTable.tsx or DataList.tsx and confirm TypeScript errors on the column with size: 'content'.
  4. ...
  5. Celebrate

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud

nx-cloud Bot commented Jun 17, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 0d74ba0


☁️ Nx Cloud last updated this comment at 2026-06-17 20:27:26 UTC

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.89%. Comparing base (880fb1e) to head (0d74ba0).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3378      +/-   ##
==========================================
- Coverage   90.38%   89.89%   -0.50%     
==========================================
  Files         398      270     -128     
  Lines        6576     5660     -916     
  Branches     2132     1905     -227     
==========================================
- Hits         5944     5088     -856     
+ Misses        624      564      -60     
  Partials        8        8              
Flag Coverage Δ
main ?
pull-request 89.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

@codecademydev

Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 72.0.3-alpha.982f9f.0 npm diff
@codecademy/gamut-icons 9.57.10-alpha.982f9f.0 npm diff
@codecademy/gamut-illustrations 0.58.16-alpha.982f9f.0 npm diff
@codecademy/gamut-kit 3.0.3-alpha.982f9f.0 npm diff
@codecademy/gamut-patterns 0.10.35-alpha.982f9f.0 npm diff
@codecademy/gamut-styles 20.0.3-alpha.982f9f.0 npm diff
@codecademy/gamut-tests 6.0.6-alpha.982f9f.0 npm diff
@codecademy/variance 0.26.2-alpha.982f9f.0 npm diff
eslint-plugin-gamut 2.4.4-alpha.982f9f.0 npm diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants