Birmingham | may-2026-itp | Alexandra Clincu | Sprint 1 | Form Controls - #1285
Closed
AlexandraClincu28 wants to merge 3 commits into
Closed
Birmingham | may-2026-itp | Alexandra Clincu | Sprint 1 | Form Controls#1285AlexandraClincu28 wants to merge 3 commits into
AlexandraClincu28 wants to merge 3 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
AlexandraClincu28
added
the
Needs Review
Poonam-raj
added
Review in progress
Poonam-raj
reviewed
May 19, 2026
Comment on lines
+20
to
+26
| <label for="colour">Choose a colour:</label> | ||
| <select id="colour" name="colour" required> | ||
| <option value="">Select a colour</option> | ||
| <option value="black">Black</option> | ||
| <option value="white">White</option> | ||
| <option value="blue">Blue</option> | ||
| </select> |
Contributor
There was a problem hiding this comment.
It might be nice to wrap this in a fieldset tag as it can create a bit of structure around a part of the form that is related to one idea, or separate an element out
Poonam-raj
reviewed
May 19, 2026
Comment on lines
+27
to
+36
| <label for="size">Choose a size:</label> | ||
| <select id="size" name="size" required> | ||
| <option value="">Select a size</option> | ||
| <option value="XS">XS</option> | ||
| <option value="S">S</option> | ||
| <option value="M">M</option> | ||
| <option value="L">L</option> | ||
| <option value="XL">XL</option> | ||
| <option value="XXL">XXL</option> | ||
| </select> |
Contributor
There was a problem hiding this comment.
It might be nice to also wrap this in a fieldset tag
Poonam-raj
reviewed
May 19, 2026
Comment on lines
+16
to
+17
| <label for="name">Name:</label> | ||
| <input type="text" id="name" name="name" required minlength="2" /> |
Contributor
There was a problem hiding this comment.
Nice work - I do get the right level of strictness here 🎉
Poonam-raj
reviewed
May 19, 2026
| <label for="name">Name:</label> | ||
| <input type="text" id="name" name="name" required minlength="2" /> | ||
| <label for="email">Email:</label> | ||
| <input type="email" id="email" name="email" required /> |
Contributor
There was a problem hiding this comment.
good validation of email by using the type field
Poonam-raj
reviewed
May 19, 2026
Poonam-raj
left a comment
Poonam-raj
left a comment
Contributor
There was a problem hiding this comment.
Good work here - this is complete, I would advise to make this even better by adding fieldsets but otherwise looks great
Poonam-raj
added
Reviewed
Member
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I created a valid HTML form with name, email, colour and size inputs using HTML form controls and validation.