Skip to content

London | 26-ITP-May | Russom Gebremeskel | Sprint 3 | Quote Generator #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
russom-g wants to merge 1 commit into
base: main
Choose a base branch
from
+54 −2
Open

London | 26-ITP-May | Russom Gebremeskel | Sprint 3 | Quote Generator #1438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Sprint-3/quote-generator/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Title here</title>
<title>Quote generator app"</title>
<script defer src="quotes.js"></script>
<link rel="stylesheet" href="style.css">
</head>
<body>
<h1>hello there</h1>
<h1>Welcome</h1>
<p id="quote"></p>
<p id="author"></p>
<button type="button" id="new-quote">New quote</button>
Expand Down
24 changes: 24 additions & 0 deletions Sprint-3/quote-generator/quotes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
// pickFromArray(['a','b','c','d']) // maybe returns 'c'

// You don't need to change this function

function pickFromArray(choices) {
return choices[Math.floor(Math.random() * choices.length)];
}
Expand Down Expand Up @@ -490,4 +491,27 @@ const quotes = [
},
];

//console.log(pickFromArray(quotes));
// call pickFromArray with the quotes array to check you get a random quote

//When the page loads it should show a random quote from the `quotes` array on the screen. It should also show who said the quote.

//When you click a button on the screen it should change the quote on the screen.

const button = document.querySelector("#new-quote");
const quoteText = document.querySelector("#quote");
const quoteAuthor = document.querySelector("#author");

function showRandomQuote() {
const randomQuote = pickFromArray(quotes);
quoteText.textContent = randomQuote.quote;
quoteAuthor.textContent = randomQuote.author;
}

showRandomQuote();

button.addEventListener("click", showRandomQuote);

//function pickFromArray(choices) {
// return choices[Math.floor(Math.random() * choices.length)];
//}
Comment on lines +515 to +517

@cjyuan cjyuan Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused code should be removed to keep the code base clean.

27 changes: 27 additions & 0 deletions Sprint-3/quote-generator/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,28 @@
/** Write your CSS in here **/

body {
color: rgb(48, 46, 46);
background-color: rgb(238, 235, 235);
font-family: Arial, sans-serif;
margin: 0;
padding: 20px;
}

h1 {
text-align: center;
font-size: 2.5rem;
color: ;
}

p {
font-size: 1rem;
color: ;
}

button {
background-color: rgb(221, 235, 116);
color: rgb(131, 95, 29);
border: none;
padding: 10px;
border-radius: 5px;
}
Loading