Skip to content

London| 26-ITP-May | Mandip Sanger | Sprint 3 | Alarm Clock #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mandipsanger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

London| 26-ITP-May | Mandip Sanger | Sprint 3 | Alarm Clock #1435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,41 @@
function setAlarm() {}
let timer;

function setAlarm() {
const input = document.getElementById("alarmSet");
const heading = document.getElementById("timeRemaining");

let timeRemaining = Number(input.value);

@cjyuan cjyuan Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using raw input without validation is a dangerous practice. Is there any value this app should reject?

  • Is the input a number?
  • What type of number should it be?
  • What is the acceptable range of numbers?


function formatTime(totalSeconds) {
const minutes = Math.floor(totalSeconds / 60);
const seconds = totalSeconds % 60;

return `Time Remaining: ${String(minutes).padStart(2, "0")}:${String(
seconds
).padStart(2, "0")}`;
}

// Show starting time
heading.innerText = formatTime(timeRemaining);

// Stop an existing timer
clearInterval(timer);

timer = setInterval(() => {
timeRemaining--;

if (timeRemaining <= 0) {
timeRemaining = 0;
heading.innerText = formatTime(timeRemaining);

clearInterval(timer);
playAlarm();
return;
}

heading.innerText = formatTime(timeRemaining);
}, 1000);
}

// DO NOT EDIT BELOW HERE

Expand Down
Loading