London | 26-ITP-May | Edina Kurdi | Sprint 3 | Quote Generator - #1426
Open
edinakurdi wants to merge 10 commits into
Open
London | 26-ITP-May | Edina Kurdi | Sprint 3 | Quote Generator#1426edinakurdi wants to merge 10 commits into
edinakurdi wants to merge 10 commits into
Conversation
edinakurdi
added
📅 Sprint 3
9 tasks
cjyuan
reviewed
Aug 14, 2026
| ]; | ||
|
|
||
| // call pickFromArray with the quotes array to check you get a random quote | ||
| console.log(pickFromArray(quotes)); //object gets logged into the console initially |
Contributor
There was a problem hiding this comment.
Note: After checking, it is better to remove all code not needed by the app (to keep the code clean).
|
|
||
| // call pickFromArray with the quotes array to check you get a random quote | ||
| console.log(pickFromArray(quotes)); //object gets logged into the console initially | ||
| displayQuote(pickFromArray(quotes)); |
Contributor
There was a problem hiding this comment.
Could consider placing all code that runs once on page load in a single function. For example, you could put it inside the page load callback or create a function named init() or setup() and call it once when the page loads.
This makes it easier to locate and manage all the code that runs once when the app starts.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented quote generator
Added some css