Cape Town | 26-ITP-May | Enice Mutanda | Sprint 3 |Quote Generator - #1421
Open
Enice-Codes wants to merge 2 commits into
Open
Cape Town | 26-ITP-May | Enice Mutanda | Sprint 3 |Quote Generator#1421Enice-Codes wants to merge 2 commits into
Enice-Codes wants to merge 2 commits into
Conversation
Enice-Codes
added
the
Needs Review
cjyuan
added
Review in progress
cjyuan
reviewed
Aug 14, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
App works.
Note: It is a best practice to respect instructions like // DO NOT EDIT BELOW HERE.
Comment on lines
+523
to
+524
| quoteEl.textContent = `"${randomQuote.quote}"`; | ||
| authorEl.textContent = `— ${randomQuote.author}`; |
Contributor
There was a problem hiding this comment.
The leading " and - appear to be for styling purposes. Keeping them in the HTML or in CSS would make it easier to style or modify the view. This allows front-end developers to adjust the UI without changing any JavaScript code.
Author
There was a problem hiding this comment.
removed the "" and - from js file to css and html.i dint think it mattered
cjyuan
added
Reviewed
Enice-Codes
added
Needs Review
cjyuan
reviewed
Aug 15, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look great. Well done.
Comment on lines
+51
to
+59
| quotes: '"' '"'; | ||
| } | ||
|
|
||
| #quote::before { | ||
| content: open-quote; | ||
| } | ||
|
|
||
| #quote::after { | ||
| content: close-quote; |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Styled the qoute with css
added a title to the html
called the function on j.s