Cape Town | 26-ITP-May |Enice Mutanda | Sprint 3| Feature/book library - #567
Open
Enice-Codes wants to merge 2 commits into
Open
Cape Town | 26-ITP-May |Enice Mutanda | Sprint 3| Feature/book library#567Enice-Codes wants to merge 2 commits into
Enice-Codes wants to merge 2 commits into
Conversation
correct invalid HTML in book-library form - Add proper page title - Split malformed charset/viewport meta tag into two valid tags - Fix invalid input types (title/author) to type="text" - Properly associate checkbox label with for/id
- Fix Robinson Crusoe title typo - Use myLibrary instead of undefined library in submit() - Pass author.value instead of duplicate title.value - Add missing closing parenthesis in render() loop - Fix delButton variable name mismatch - Correct "clicks" event typo to "click" - Fix read/unread status logic
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
index.html*
<title><meta>tag into two valid tagstype="title",type="author") totype="text"idusingforscript.js
submit()referencing an undefinedlibraryvariable — now correctly usesmyLibrarysubmit()passingtitle.valuetwice instead ofauthor.valuewhen creating a new bookrender()for-loop (syntax error)delButton/delButvariable names causing a reference error"clicks"typo in event listener — corrected to"click"so the delete button works