Skip to content

Cape Town | 26-ITP-May |Enice Mutanda | Sprint 3| Feature/book library - #567

Open
Enice-Codes wants to merge 2 commits into
CodeYourFuture:mainfrom
Enice-Codes:Feature/book-library
Open

Cape Town | 26-ITP-May |Enice Mutanda | Sprint 3| Feature/book library#567
Enice-Codes wants to merge 2 commits into
CodeYourFuture:mainfrom
Enice-Codes:Feature/book-library

Conversation

@Enice-Codes

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

index.html*

  • Added a proper page <title>
  • Split the malformed combined charset/viewport <meta> tag into two valid tags
  • Fixed invalid input types (type="title", type="author") to type="text"
  • Properly associated the "Read" checkbox label with its id using for

script.js

  • Fixed typo in "Robinson Crusoe" book title
  • Fixed submit() referencing an undefined library variable — now correctly uses myLibrary
  • Fixed submit() passing title.value twice instead of author.value when creating a new book
  • Fixed missing closing parenthesis in the render() for-loop (syntax error)
  • Fixed mismatched delButton/delBut variable names causing a reference error
  • Fixed "clicks" typo in event listener — corrected to "click" so the delete button works
  • Fixed read/unread status logic so the button label matches the book's actual read state

 correct invalid HTML in book-library form

- Add proper page title
- Split malformed charset/viewport meta tag into two valid tags
- Fix invalid input types (title/author) to type="text"
- Properly associate checkbox label with for/id

- Fix Robinson Crusoe title typo
- Use myLibrary instead of undefined library in submit()
- Pass author.value instead of duplicate title.value
- Add missing closing parenthesis in render() loop
- Fix delButton variable name mismatch
- Correct "clicks" event typo to "click"
- Fix read/unread status logic
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 19, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 19, 2026
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes added the NotCoursework A PR that edits material in the module. Needs review by the curriculum team. label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NotCoursework A PR that edits material in the module. Needs review by the curriculum team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant