Skip to content

Cape Town | 26-ITP-May | Shafiek Walker | Sprint 2 | Book Library - #566

Open
shafiekwalker7861 wants to merge 2 commits into
CodeYourFuture:mainfrom
shafiekwalker7861:book-library-fixes
Open

Cape Town | 26-ITP-May | Shafiek Walker | Sprint 2 | Book Library#566
shafiekwalker7861 wants to merge 2 commits into
CodeYourFuture:mainfrom
shafiekwalker7861:book-library-fixes

Conversation

@shafiekwalker7861

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Fixed the Book Library application bugs.

  • Fixed syntax error preventing books from loading
  • Fixed the incorrect library array reference when adding books
  • Fixed author input so the correct author is saved
  • Added validation for missing title, author and page information
  • Fixed read/unread status
  • Fixed read status toggle
  • Fixed delete button functionality
  • Fixed incorrect delete event listener
  • Cleared the form after successfully adding a book

Testing

Tested:

  • Initial books load correctly
  • New books can be added
  • Missing fields are rejected
  • Read status is saved correctly
  • Read/unread status can be toggled
  • Books can be deleted
  • No console errors

@shafiekwalker7861 shafiekwalker7861 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 18, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coud you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 18, 2026
@shafiekwalker7861

Copy link
Copy Markdown
Author

Hi @cjyuan , thank you for the feedback. I reviewed the general feedback and made further improvements to the Book Library, including HTML validation, cleaner DOM variable names, numeric page counts, module-based script loading, improved table rendering, and non-blocking delete feedback. The changes have been pushed to the PR for review.

@shafiekwalker7861 shafiekwalker7861 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 18, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 18, 2026
@shafiekwalker7861

shafiekwalker7861 commented Aug 18, 2026 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants