Cape Town | 26-ITP-May | Shafiek Walker | Sprint 2 | Book Library - #566
Open
shafiekwalker7861 wants to merge 2 commits into
Open
Cape Town | 26-ITP-May | Shafiek Walker | Sprint 2 | Book Library#566shafiekwalker7861 wants to merge 2 commits into
shafiekwalker7861 wants to merge 2 commits into
Conversation
10 tasks
cjyuan
reviewed
Aug 18, 2026
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Coud you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
Author
|
Hi @cjyuan , thank you for the feedback. I reviewed the general feedback and made further improvements to the Book Library, including HTML validation, cleaner DOM variable names, numeric page counts, module-based script loading, improved table rendering, and non-blocking delete feedback. The changes have been pushed to the PR for review. |
Author
|
Thanks, CJ
…On Tue, Aug 18, 2026 at 2:43 PM CJ Yuan ***@***.***> wrote:
***@***.**** commented on this pull request.
Looks good. Well done.
—
Reply to this email directly, view it on GitHub
<#566?email_source=notifications&email_token=A4CDQ6VBFQPN6C6CPO4U26T5KRFO7A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJWGEYTANRUGQZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4961106443>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4CDQ6RCL7QYCLHODJLG4TL5KRFO7AVCNFSNUABFKJSXA33TNF2G64TZHM3TSOJSGQ2TQMRXHNEXG43VMU5TKMJYGA4TKMZRHA4KC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/A4CDQ6TU7AMG5YHFNAZNIHD5KRFO7A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJWGEYTANRUGQZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/A4CDQ6VYXF6LCSBW7NWPMLD5KRFO7A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJWGEYTANRUGQZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Fixed the Book Library application bugs.
Testing
Tested: