-
-
Notifications
You must be signed in to change notification settings - Fork 270
London | 26-ITP-May | Zadri Abdule | Sprint 2 | Book - library #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+105
−94
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,103 +1,115 @@ | ||
| let myLibrary = []; | ||
| const myLibrary = []; | ||
|
|
||
| window.addEventListener("load", function (e) { | ||
| populateStorage(); | ||
| render(); | ||
| }); | ||
|
|
||
| function populateStorage() { | ||
| if (myLibrary.length == 0) { | ||
| let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); | ||
| let book2 = new Book( | ||
| // Seed with a couple of books if library is empty | ||
| if (myLibrary.length === 0) { | ||
| const book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true); | ||
| const book2 = new Book( | ||
| "The Old Man and the Sea", | ||
| "Ernest Hemingway", | ||
| "127", | ||
| 127, | ||
| true | ||
| ); | ||
| myLibrary.push(book1); | ||
| myLibrary.push(book2); | ||
| render(); | ||
| myLibrary.push(book1, book2); | ||
| } | ||
| } | ||
|
|
||
| const title = document.getElementById("title"); | ||
| const author = document.getElementById("author"); | ||
| const pages = document.getElementById("pages"); | ||
| const check = document.getElementById("check"); | ||
| const titleInput = document.getElementById("title"); | ||
| const authorInput = document.getElementById("author"); | ||
| const pagesInput = document.getElementById("pages"); | ||
| const checkInput = document.getElementById("check"); | ||
|
|
||
| //check the right input from forms and if its ok -> add the new book (object in array) | ||
| //via Book function and start render function | ||
| function submit() { | ||
| if ( | ||
| title.value == null || | ||
| title.value == "" || | ||
| pages.value == null || | ||
| pages.value == "" | ||
| ) { | ||
| alert("Please fill all fields!"); | ||
| function addBook() { | ||
| const title = titleInput.value.trim(); | ||
| const author = authorInput.value.trim(); | ||
| const pagesRaw = pagesInput.value.trim(); | ||
| const pages = Number(pagesRaw); | ||
|
|
||
| // Validate AFTER trimming, so whitespace-only input is rejected too | ||
| if (!title || !author || !pagesRaw || !Number.isFinite(pages) || pages <= 0) { | ||
| alert("Please fill all fields with valid values!"); | ||
| return false; | ||
| } else { | ||
| let book = new Book(title.value, title.value, pages.value, check.checked); | ||
| library.push(book); | ||
| render(); | ||
| } | ||
|
|
||
| const book = new Book(title, author, pages, checkInput.checked); | ||
| myLibrary.push(book); | ||
|
|
||
| // clear form inputs | ||
| titleInput.value = ""; | ||
| authorInput.value = ""; | ||
| pagesInput.value = ""; | ||
| checkInput.checked = false; | ||
|
|
||
| render(); | ||
| return true; | ||
| } | ||
|
|
||
| function Book(title, author, pages, check) { | ||
| function Book(title, author, pages, read) { | ||
| this.title = title; | ||
| this.author = author; | ||
| this.pages = pages; | ||
| this.check = check; | ||
| this.pages = pages; // stored as a Number now, not a trimmed string | ||
| // store as boolean under a descriptive property | ||
| this.read = !!read; | ||
| } | ||
|
|
||
| function render() { | ||
| let table = document.getElementById("display"); | ||
| let rowsNumber = table.rows.length; | ||
| //delete old table | ||
| for (let n = rowsNumber - 1; n > 0; n-- { | ||
| table.deleteRow(n); | ||
| } | ||
| //insert updated row and cells | ||
| let length = myLibrary.length; | ||
| for (let i = 0; i < length; i++) { | ||
| let row = table.insertRow(1); | ||
| let titleCell = row.insertCell(0); | ||
| let authorCell = row.insertCell(1); | ||
| let pagesCell = row.insertCell(2); | ||
| let wasReadCell = row.insertCell(3); | ||
| let deleteCell = row.insertCell(4); | ||
| titleCell.innerHTML = myLibrary[i].title; | ||
| authorCell.innerHTML = myLibrary[i].author; | ||
| pagesCell.innerHTML = myLibrary[i].pages; | ||
|
|
||
| //add and wait for action for read/unread button | ||
| let changeBut = document.createElement("button"); | ||
| changeBut.id = i; | ||
| changeBut.className = "btn btn-success"; | ||
| wasReadCell.appendChild(changeBut); | ||
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| readStatus = "No"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
|
|
||
| changeBut.addEventListener("click", function () { | ||
| myLibrary[i].check = !myLibrary[i].check; | ||
| const table = document.getElementById("display"); | ||
| const tbody = table.getElementsByTagName("tbody")[0]; | ||
|
|
||
| // Clear existing rows in one operation instead of removing one at a time | ||
| tbody.innerHTML = ""; | ||
|
|
||
| myLibrary.forEach((book) => { | ||
| const row = document.createElement("tr"); | ||
|
|
||
| const titleCell = document.createElement("td"); | ||
| titleCell.textContent = book.title; | ||
| row.appendChild(titleCell); | ||
|
|
||
| const authorCell = document.createElement("td"); | ||
| authorCell.textContent = book.author; | ||
| row.appendChild(authorCell); | ||
|
|
||
| const pagesCell = document.createElement("td"); | ||
| pagesCell.textContent = book.pages; | ||
| row.appendChild(pagesCell); | ||
|
|
||
| const wasReadCell = document.createElement("td"); | ||
| const changeBut = document.createElement("button"); | ||
| changeBut.className = "btn btn-sm btn-outline-primary"; | ||
| changeBut.textContent = book.read ? "Yes" : "No"; | ||
| changeBut.addEventListener("click", () => { | ||
| book.read = !book.read; | ||
| render(); | ||
| }); | ||
| wasReadCell.appendChild(changeBut); | ||
| row.appendChild(wasReadCell); | ||
|
|
||
| //add delete button to every row and render again | ||
| let delButton = document.createElement("button"); | ||
| delBut.id = i + 5; | ||
| deleteCell.appendChild(delBut); | ||
| delBut.className = "btn btn-warning"; | ||
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| alert(`You've deleted title: ${myLibrary[i].title}`); | ||
| myLibrary.splice(i, 1); | ||
| render(); | ||
| const deleteCell = document.createElement("td"); | ||
| const delBut = document.createElement("button"); | ||
| delBut.className = "btn btn-sm btn-danger"; | ||
| delBut.textContent = "Delete"; | ||
| delBut.addEventListener("click", () => { | ||
| if (confirm(`Delete "${book.title}"?`)) { | ||
| // Look up by object identity, not by closure-captured index, | ||
| // so this stays correct even if myLibrary is ever reordered | ||
| // by something other than a full render(). | ||
| const idx = myLibrary.indexOf(book); | ||
| if (idx === -1) return; | ||
| myLibrary.splice(idx, 1); | ||
| render(); | ||
| } | ||
| }); | ||
| } | ||
| deleteCell.appendChild(delBut); | ||
| row.appendChild(deleteCell); | ||
|
|
||
| tbody.appendChild(row); | ||
| }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,16 @@ | ||
| .form-group { | ||
| width: 400px; | ||
| height: 300px; | ||
| align-self: left; | ||
| padding-left: 20px; | ||
| #toast { | ||
| position: fixed; | ||
| bottom: 1rem; | ||
| left: 50%; | ||
| transform: translateX(-50%); | ||
| background: #333; | ||
| color: #fff; | ||
| padding: 0.5rem 1rem; | ||
| border-radius: 0.25rem; | ||
| opacity: 0; | ||
| pointer-events: none; | ||
| transition: opacity 0.3s ease; | ||
| } | ||
|
|
||
| .btn { | ||
| display: block; | ||
| } | ||
|
|
||
| .form-check-label { | ||
| padding-left: 20px; | ||
| margin: 5px 0px 5px 0px; | ||
| } | ||
|
|
||
| button.btn-info { | ||
| margin: 20px; | ||
| #toast.show { | ||
| opacity: 1; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Look up the trade-off between
.addEventListener()