London | 26-ITP-May | Russom Gebremeskel | Sprint 2 | Book Library - #562
Open
russom-g wants to merge 30 commits into
Open
London | 26-ITP-May | Russom Gebremeskel | Sprint 2 | Book Library #562russom-g wants to merge 30 commits into
russom-g wants to merge 30 commits into
Conversation
added 16 commits
August 5, 2026 00:16
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
russom-g
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
russom-g
changed the title
This comment has been minimized.
This comment has been minimized.
russom-g
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
russom-g
changed the title
This comment has been minimized.
This comment has been minimized.
russom-g
changed the title
russom-g
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
russom-g
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
russom-g
added
the
Needs Review
cjyuan
reviewed
Aug 17, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Could consider placing all code that runs once on page load in a single function. For example, you could put it inside the page load callback or create a function named init() or setup() and call it once when the page loads.
This makes it easier to locate and manage all the code that runs once when the app starts.
cjyuan
added
Reviewed
Author
|
Thanks for the feedback. Now a setup function is implemented. Both populateStorage and render function are wrapped inside the function. |
cjyuan
reviewed
Aug 18, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
-
Could you remove
.vscode/settings.jsonand revert the changes made in.gitignore? Otherwise the validation bot will reject this PR. -
Could you also check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.mdDoing so can help me speed up the review process. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Bug fixed. Dead code removed.