Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 2 | Book Library

[KhotKeys]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Fixed all bugs in the book library, specifically:

• fixed a syntax error in the for loop in the render function.
• fixed the submit function using the wrong variable name (library instead of myLibrary).
• fixed the author field using title value instead of author value.
• fixed the delete button variable name mismatch (delBut vs delButton) and wrong event name (clicks instead of click).
• fixed the inverted read status logic showing wrong Yes/No values.

Questions

None.

[cjyuan]

Could you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

[cjyuan]

Changes look good.

I only have a few suggestions.

[cjyuan]

Changes look good.

[cjyuan]

Could consider

• Define the "on submit" callback function as a named function.
• Place the "callback setup" statement together with all the code that run once on page load in a single function. For example, you could put it inside the page load callback or create a function named init() or setup() and call it once when the page loads.

Doing so could make it easier to locate and manage all the code that runs once when the app starts.

[KhotKeys]

Perfect, let me fall back and add those, thank you so much

Could consider

• Define the "on submit" callback function as a named function.
• Place the "callback setup" statement together with all the code that run once on page load in a single function. For example, you could put it inside the page load callback or create a function named init() or setup() and call it once when the page loads.

Doing so could make it easier to locate and manage all the code that runs once when the app starts.

Perfect, let me fall back and add those, thank you so much