Skip to content

London | 26-ITP-May | Dagim Daniel | Sprint 2 | book library #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dagim-Daniel wants to merge 4 commits into
base: main
Choose a base branch
from
+133 −135
Open

London | 26-ITP-May | Dagim Daniel | Sprint 2 | book library #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53e7964
fixing major bugs of the book library project
Dagim-Daniel Aug 11, 2026
6864b9f
fixing the common naming issue of script js
Dagim-Daniel Aug 12, 2026
e613ec3
fix book library based on the comments including validation to acce…
Dagim-Daniel Aug 16, 2026
a65e0e3
fixed based on the comment including the delete alert to come after t…
Dagim-Daniel Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 46 additions & 51 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html>
<!doctype html>
<html lang="en">
<head>
<title> </title>
<title>Book Library</title>
<meta
charset="utf-8"
name="viewport"
Expand All @@ -28,46 +28,49 @@ <h1>Library</h1>
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<form id="bookForm">
<div class="form-group">
<label for="title">Title:</label>
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
type="text"
class="form-control"
id="title"
name="title"
required
/>
</div>

<div class="form-group">
<label for="author">Author:</label>
<input
type="text"
class="form-control"
id="author"
name="author"
required
/>
</div>

<div class="form-group">
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
min="1"
step="1"
required
/>
</div>

<div class="form-group form-check">
<input type="checkbox" class="form-check-input" id="check" />
<label class="form-check-label" for="check">Read</label>
</div>

<button type="submit" class="btn btn-primary">Submit</button>
</form>
</div>

<table class="table" id="display">
Expand All @@ -80,15 +83,7 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
<tbody></tbody>
</table>

<script src="script.js"></script>
Expand Down
155 changes: 84 additions & 71 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,27 @@
let myLibrary = [];
// 1 & 3. Constant array and top-level DOM element declarations
const myLibrary = [];
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const readCheckbox = document.getElementById("check");

window.addEventListener("load", function (e) {
window.addEventListener("load", function () {
populateStorage();
render();

const bookForm = document.getElementById("bookForm");
if (bookForm) {
bookForm.addEventListener("submit", addBook);
}
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
if (myLibrary.length === 0) {
// 2. Constructor called with PascalCase
let book1 = new LibraryBook("Robinson Crusoe", "Daniel Defoe", 252, true);
let book2 = new LibraryBook(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
Expand All @@ -20,84 +30,87 @@ function populateStorage() {
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
function addBook(e) {
e.preventDefault();

// 4. Input preprocessing and consistent usage of cleaned values
const cleanTitle = titleInput.value.trim();
const cleanAuthor = authorInput.value.trim();
const cleanPages = parseInt(pagesInput.value, 10);

if (!cleanTitle || !cleanAuthor || isNaN(cleanPages) || cleanPages < 1) {
alert("Please provide a valid title, author, and positive page count!");
return;
}

const newBook = new LibraryBook(
cleanTitle,
cleanAuthor,
cleanPages,
readCheckbox.checked
);

myLibrary.push(newBook);
document.getElementById("bookForm").reset();
render();
}

function Book(title, author, pages, check) {
// 2. PascalCase constructor function
function LibraryBook(title, author, pages, isRead) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
this.isRead = isRead;
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
// 5. Efficient single-operation clearing of <tbody>
const tableBody = document.querySelector("#display tbody");
tableBody.textContent = "";

const libraryLength = myLibrary.length;
for (let i = 0; i < libraryLength; i++) {
const row = tableBody.insertRow();
const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const readStatusCell = row.insertCell(3);
const deleteCell = row.insertCell(4);

titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

// Read status toggle button
const toggleReadBtn = document.createElement("button");
// 6. No unnecessary ID attribute assignment
toggleReadBtn.className = "btn btn-success";
toggleReadBtn.textContent = myLibrary[i].isRead ? "Yes" : "No";

toggleReadBtn.addEventListener("click", function () {
myLibrary[i].isRead = !myLibrary[i].isRead;
render();
});
readStatusCell.appendChild(toggleReadBtn);

// Delete button
const deleteBtn = document.createElement("button");
// 6. No unnecessary ID attribute assignment
deleteBtn.className = "btn btn-warning";
deleteBtn.textContent = "Delete";

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
deleteBtn.addEventListener("click", function () {
const deletedTitle = myLibrary[i].title;

// 7. Delete from array and re-render DOM BEFORE triggering the alert
myLibrary.splice(i, 1);
render();

// Defer alert so the browser completes its UI repaint first
setTimeout(() => {
alert(`You've deleted title: ${deletedTitle}`);
}, 0);
});
deleteCell.appendChild(deleteBtn);
}
}
16 changes: 3 additions & 13 deletions debugging/book-library/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,7 @@
.form-group {
width: 400px;
height: 300px;
align-self: left;
#bookForm {
max-width: 400px;
padding-left: 20px;
}

.btn {
display: block;
}

.form-check-label {
padding-left: 20px;
margin: 5px 0px 5px 0px;
margin-bottom: 20px;
}

button.btn-info {
Expand Down
Loading