feat(updater): enable GitHub Releases auto-updates#6
Merged
Conversation
Wire NativePHP electron-updater to GitHub Releases, keep write tokens out of the build env, and scan dist artifacts for leaked GitHub token patterns before upload.
A failing grep-based scan can print matches into public Actions logs, which is worse than the protection it adds when no write token is present in the build env.
Separate arm64/x64 jobs each wrote latest-mac.yml; merging artifacts left only one arch in the release feed. NativePHP mac+all runs electron-builder once for both arches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GITHUB_PRIVATE=false).Security
GITHUB_TOKEN/GH_TOKENin the build job (we usenative:build, not--publish)..envstill stripsGITHUB_*viacleanup_env_keys.Test plan
v*release (or workflow_dispatch) and confirm builds attach*.yml/ installers