Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 113 additions & 15 deletions CHANGELOG.md

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions build_examples.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#!/bin/sh
LIB_VER=$(grep '<revision>' pom.xml | sed -e 's|[[:space:]]*<[/]*revision>[[:space:]]*||g')
find `pwd`/examples -type f -name pom.xml -exec sed -i -e "s|\(<clickhouse-java.version>\).*\(<\)|\1$LIB_VER\2|g" {} \;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GNU sed breaks on macOS

Medium Severity

The new script uses sed -i -e as in Linux CI, but BSD sed on macOS treats the argument after -i as a backup extension, so in-place edits of example pom.xml files fail or behave incorrectly on developer Macs.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 73156f8. Configure here.

for d in $(ls -d `pwd`/examples/*/); do \
if [ -e $d/pom.xml ]; then cd $d && mvn --batch-mode --no-transfer-progress clean compile; fi;
if [ -e $d/gradlew ]; then cd $d && ./gradlew clean build; fi;
done

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script ignores build failures

Medium Severity

The new build_examples.sh loops over examples and runs mvn clean compile or ./gradlew clean build without set -e or checking exit codes. If an early example fails, the loop keeps going and the script can still exit successfully depending on the last command, masking broken examples during local release checks.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 73156f8. Configure here.


2 changes: 1 addition & 1 deletion examples/client-v2-json-processors/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.release>17</maven.compiler.release>

<clickhouse-java.version>0.9.8-SNAPSHOT</clickhouse-java.version>
<clickhouse-java.version>0.10.0-rc1-SNAPSHOT</clickhouse-java.version>
<jackson.version>2.22.0</jackson.version>
<gson.version>2.14.0</gson.version>
<slf4j.version>2.0.17</slf4j.version>
Expand Down
2 changes: 1 addition & 1 deletion examples/client-v2/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

<clickhouse-java.version>0.9.8-SNAPSHOT</clickhouse-java.version>
<clickhouse-java.version>0.10.0-rc1-SNAPSHOT</clickhouse-java.version>

<compiler-plugin.version>3.8.1</compiler-plugin.version>

Expand Down
4 changes: 2 additions & 2 deletions examples/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

<clickhouse-java.version>0.9.8-SNAPSHOT</clickhouse-java.version>
<clickhouse-java.version>0.10.0-rc1-SNAPSHOT</clickhouse-java.version>
<!-- Nightly snapshot version from https://central.sonatype.com/repository/maven-snapshots/or latest from local -->
<!-- <clickhouse-java.version>0.9.8-SNAPSHOT</clickhouse-java.version>-->
<!-- <clickhouse-java.version>0.10.0-rc1-SNAPSHOT</clickhouse-java.version>-->

<apache-httpclient.version>5.2.1</apache-httpclient.version>

Expand Down
2 changes: 1 addition & 1 deletion examples/demo-kotlin-service/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ ktor_version=2.3.12
kotlin_version=2.0.20
logback_version=1.4.14

ch_java_client_version=0.9.8
ch_java_client_version=0.10.0-rc1
2 changes: 1 addition & 1 deletion examples/demo-service/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

ch_java_client_version=0.9.8
ch_java_client_version=0.10.0-rc1
2 changes: 1 addition & 1 deletion examples/jdbc-v2-json-processors/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.release>17</maven.compiler.release>

<clickhouse-java.version>0.9.8-SNAPSHOT</clickhouse-java.version>
<clickhouse-java.version>0.10.0-rc1-SNAPSHOT</clickhouse-java.version>
<jackson.version>2.22.0</jackson.version>
<gson.version>2.14.0</gson.version>
<slf4j.version>2.0.17</slf4j.version>
Expand Down
2 changes: 1 addition & 1 deletion examples/jdbc/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

<clickhouse-java.version>0.9.8-SNAPSHOT</clickhouse-java.version>
<clickhouse-java.version>0.10.0-rc1-SNAPSHOT</clickhouse-java.version>
<hikaricp.version>4.0.3</hikaricp.version>
<apache-httpclient.version>5.2.1</apache-httpclient.version>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<properties>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<clickhouse-java.version>0.9.8-SNAPSHOT</clickhouse-java.version>
<clickhouse-java.version>0.10.0-rc1-SNAPSHOT</clickhouse-java.version>
<spring-boot-starter.version>2.7.18</spring-boot-starter.version>
</properties>

Expand Down
2 changes: 1 addition & 1 deletion performance/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<properties>
<apache.httpclient.version>5.3.1</apache.httpclient.version>
<slf4j.version>2.0.17</slf4j.version>
<ch.jdbc.revision>0.9.8-SNAPSHOT</ch.jdbc.revision>
<ch.jdbc.revision>0.10.0-rc1-SNAPSHOT</ch.jdbc.revision>
<jmh.version>1.37</jmh.version>
<testcontainers.version>2.0.2</testcontainers.version>

Expand Down
10 changes: 5 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@

<developers>
<developer>
<id>zhicwu</id>
<name>Zhichun Wu</name>
<email>zhicwu@gmail.com</email>
<timezone>+8</timezone>
<id>sergey_chernov</id>
<name>Sergey Chernov</name>
<email>sergey.chernov@clickhouse.com</email>
<timezone>-8</timezone>
</developer>
</developers>

Expand Down Expand Up @@ -69,7 +69,7 @@
</ciManagement>

<properties>
<revision>0.9.8-SNAPSHOT</revision>
<revision>0.10.0-rc1-SNAPSHOT</revision>
<project.current.year>2026</project.current.year>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
Expand Down
Loading