fix(meta): avoid duplicate logs for expected Graph API errors - #869
Open
AlanSyue wants to merge 1 commit into
Open
fix(meta): avoid duplicate logs for expected Graph API errors#869AlanSyue wants to merge 1 commit into
AlanSyue wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
230and code100with subcode33as expected policy outcomes logged atwarn; unknown and genuine failures remain aterror.beforeErrorlog and log once after the Graph error payload is parsed.Root cause
The Ky
beforeErrorhook logged every HTTP failure aterrorbefore the Graph response body had been parsed. The same failure was then logged again by the integration rescue boundary. Because policy error codes were unavailable at the first boundary, expected caller-handled responses were indistinguishable from genuine faults.Security
origin + pathnamebefore logging; query strings and fragments are discarded.access_token=secretand verifies neither the query key nor value reaches the logger payload.Validation
pnpm lintpnpm --filter @chatbotx.io/integration-instagram check-typespnpm --filter @chatbotx.io/integration-instagram-facebook check-typespnpm --filter @chatbotx.io/integration-messenger check-typesgit diff --checkCoverage gates were executed without disabling thresholds. All tests passed before coverage enforcement, but the existing package-wide coverage remains below the configured 80% global threshold: