rules striping - #177
Open
jtoman wants to merge 2 commits into
Open
Conversation
shellygr
approved these changes
Aug 19, 2026
| l, curr_digest, curr_status | ||
| ): | ||
| for (k, stat) in history: | ||
| if stat != "VERIFIED" and k.rule not in expected_to_fail: |
Contributor
There was a problem hiding this comment.
if a rule is expected to fail but yielded timeout, doesn't it mean it's not covered?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the author agent to get their spec stamped by "striping" the rules across different runs. This requires the AP infrastructure to get access to a list of all the rules in a spec file. The way this PR achieves that currently is ... not great, but can be easily swapped in for a "proper"
certora-cliinvocation whenever that comes down the pipe.This necessitated adding an
exclude_rulesoption to the certora prover tool which maps directly onto the conf flag. While updating the prompts around theverify_spec/prover usage, I took the opportunity to point some outdated advice to the context documents and/or delete some advice that was mooted by more thorough treatment in said docs.